Bug 1240682
Summary: | Systemtap is broken on Rawhide | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Ruben Kerkhof <ruben> |
Component: | systemtap | Assignee: | Frank Ch. Eigler <fche> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | rawhide | CC: | bob.bogo, brolley, dsmith, fche, jistone, lberk, mjw, mleitner, nathans, scox, wcohen |
Target Milestone: | --- | Keywords: | Reopened |
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | systemtap-2.9-1.fc21 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2015-10-23 16:19:56 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Ruben Kerkhof
2015-07-07 14:02:52 UTC
I'm seeing the same thing, looking into it now. It looks like this was caused by the addition of qspinlocks in the following kernel commit: ==== commit a33fda35e3a7655fb7df756ed67822afb5ed5e8d Author: Waiman Long <Waiman.Long> Date: Fri Apr 24 14:56:30 2015 -0400 locking/qspinlock: Introduce a simple generic 4-byte queued spinlock ==== With this change we need to include linux/module.h before including linux/mutex.h. To fix your immediate problem, add the following text to /usr/share/systemtap/runtime/linux/runtime_defines.h: ==== #ifndef _LINUX_RUNTIME_DEFINES_H_ #define _LINUX_RUNTIME_DEFINES_H_ #include <linux/module.h> #include <linux/mutex.h> #endif /* _LINUX_RUNTIME_DEFINES_H_ */ ==== I'm not 100% sure if that's the final fix, but it will get you going again. The final fix ended up being a small tweak to our code generation - commit 320e1ec. <https://www.sourceware.org/git/gitweb.cgi?p=systemtap.git;a=commitdiff;h=320e1ecb16427b5769f0f5a097d80823ee1fb765> Thanks for the quick fix David! Hi David, would it be possible to do a F21 update too? It's also broken by this bug. Thanks. (In reply to Marcelo Ricardo Leitner from comment #5) > Hi David, would it be possible to do a F21 update too? It's also broken by > this bug. Thanks. Thanks for letting us know. I'll see if we can't get an update out soon for f21 (and f22). (In reply to Marcelo Ricardo Leitner from comment #5) > Hi David, would it be possible to do a F21 update too? It's also broken by > this bug. Thanks. Marcelo, Have you got a reproducer for this bug on f21? The one in comment #1 seems to work fine there. Oops. Then it depends on kernel version. I'm running a custom one, 4.2.0-rc8+, and the one in comment #0 reproduces it in here (greped for brevity): [root@localhost ~]# stap -v -e 'probe vfs.read {printf("read performed\n"); exit()}' 2>&1 | grep error include/linux/spinlock_types.h:55:14: error: ‘__ARCH_SPIN_LOCK_UNLOCKED’ undeclared here (not in a function) Pass 4: compilation failed. [man error::pass4] [root@localhost ~]# uname -r 4.2.0-rc8+ [root@localhost ~]# cat /etc/fedora-release Fedora release 21 (Twenty One) [root@localhost ~]# rpm -q systemtap systemtap-2.8-1.fc21.x86_64 I also cannot reproduce it with 4.1.6-100.fc21.x86_64. Now checking, the fix seems to be compatible with both, just yeah not strictly needed for f21.. I hope it's okay to include it anyway. systemtap-2.8-2.fc21 has been submitted as an update to Fedora 21. https://bodhi.fedoraproject.org/updates/FEDORA-2015-16095 systemtap-2.8-2.fc21 has been pushed to the Fedora 21 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update systemtap'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-16095 systemtap-2.9-1.fc21 has been submitted as an update to Fedora 21. https://bodhi.fedoraproject.org/updates/FEDORA-2015-9ef098b6d4 systemtap-2.9-1.fc21 has been pushed to the Fedora 21 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update systemtap' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-9ef098b6d4 systemtap-2.9-1.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report. |