Bug 1240742

Summary: Performance issues in provisioning after initial template selection
Product: Red Hat CloudForms Management Engine Reporter: Greg McCullough <gmccullo>
Component: ProvisioningAssignee: eclarizi
Status: CLOSED ERRATA QA Contact: Kyrylo Zvyagintsev <kzvyahin>
Severity: high Docs Contact:
Priority: high    
Version: 5.3.0CC: cpelland, fdewaley, jhardy, mfeifer, obarenbo
Target Milestone: GAKeywords: ZStream
Target Release: 5.5.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.5.0.1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1245697 (view as bug list) Environment:
Last Closed: 2015-12-08 13:22:10 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1283342    
Bug Blocks: 1245697    

Comment 3 CFME Bot 2015-07-23 16:03:24 UTC
New commit detected on manageiq/master:
https://github.com/ManageIQ/manageiq/commit/4f1406fb2116f1101e642d1a048ce8e7d0c3e3f5

commit 4f1406fb2116f1101e642d1a048ce8e7d0c3e3f5
Author:     Erik Clarizio <eclarizi>
AuthorDate: Fri Jul 10 09:01:14 2015 -0700
Commit:     Erik Clarizio <eclarizi>
CommitDate: Wed Jul 22 10:47:22 2015 -0700

    Refactor hash struct usage for allowed vms or templates
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1240742

 app/models/miq_provision_virt_workflow.rb | 49 +++++++++++++++++++------------
 1 file changed, 31 insertions(+), 18 deletions(-)

Comment 4 CFME Bot 2015-07-23 16:03:28 UTC
New commit detected on manageiq/master:
https://github.com/ManageIQ/manageiq/commit/25b8bc309ef5074d7a3a8f9efbe493698c8ecdec

commit 25b8bc309ef5074d7a3a8f9efbe493698c8ecdec
Author:     Erik Clarizio <eclarizi>
AuthorDate: Fri Jul 10 12:55:53 2015 -0700
Commit:     Erik Clarizio <eclarizi>
CommitDate: Wed Jul 22 10:47:23 2015 -0700

    Refactor init_from_dialog method to prevent duplicate loops
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1240742

 app/models/miq_request_workflow.rb       | 59 +++++++++++------------
 spec/models/miq_request_workflow_spec.rb | 80 ++++++++++++++++++++++++++++++++
 2 files changed, 108 insertions(+), 31 deletions(-)

Comment 5 CFME Bot 2015-07-23 16:03:32 UTC
New commit detected on manageiq/master:
https://github.com/ManageIQ/manageiq/commit/7a29724cfc3133ff0fbb7616f5209f3a118d9d86

commit 7a29724cfc3133ff0fbb7616f5209f3a118d9d86
Author:     Erik Clarizio <eclarizi>
AuthorDate: Fri Jul 10 14:17:00 2015 -0700
Commit:     Erik Clarizio <eclarizi>
CommitDate: Thu Jul 23 08:09:07 2015 -0700

    Create new method to go through tab list by name
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1240742
    
    This is instead of the old 'get_all_dialogs' or 'get_dialog(name)' as
    those were going through all of the fields even if they didn't need to

 app/models/miq_request_workflow.rb       | 18 ++++++++++++++++++
 app/views/miq_request/_prov_wf.html.haml | 30 +++++++++++++++++-------------
 spec/models/miq_request_workflow_spec.rb | 16 ++++++++++++++++
 3 files changed, 51 insertions(+), 13 deletions(-)

Comment 6 CFME Bot 2015-07-23 16:03:36 UTC
New commit detected on manageiq/master:
https://github.com/ManageIQ/manageiq/commit/082300e18b4a1cc87470812c941d160ae81d2a9d

commit 082300e18b4a1cc87470812c941d160ae81d2a9d
Author:     Erik Clarizio <eclarizi>
AuthorDate: Mon Jul 13 11:51:30 2015 -0700
Commit:     Erik Clarizio <eclarizi>
CommitDate: Thu Jul 23 08:09:15 2015 -0700

    Address some Rubocop issues
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1240742

 app/models/miq_request_workflow.rb       | 22 +++++++++++++---------
 app/views/miq_request/_prov_wf.html.haml |  8 +++++---
 spec/models/miq_request_workflow_spec.rb |  2 +-
 3 files changed, 19 insertions(+), 13 deletions(-)

Comment 7 CFME Bot 2015-07-23 16:03:39 UTC
New commit detected on manageiq/master:
https://github.com/ManageIQ/manageiq/commit/6ab8c78c0bcc1c506b2c444ac4029c4d73f66ea1

commit 6ab8c78c0bcc1c506b2c444ac4029c4d73f66ea1
Author:     Erik Clarizio <eclarizi>
AuthorDate: Thu Jul 16 14:38:56 2015 -0700
Commit:     Erik Clarizio <eclarizi>
CommitDate: Thu Jul 23 08:09:15 2015 -0700

    Add condition in init_from_dialog to prevent overwriting existing values
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1240742

 app/models/miq_request_workflow.rb       | 1 +
 spec/models/miq_request_workflow_spec.rb | 9 +++++++++
 2 files changed, 10 insertions(+)

Comment 8 CFME Bot 2015-07-30 13:21:02 UTC
New commit detected on cfme/5.4.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=99758a1e624cf3577177ba741d46a79857dc9ddc

commit 99758a1e624cf3577177ba741d46a79857dc9ddc
Author:     Erik Clarizio <eclarizi>
AuthorDate: Fri Jul 10 09:01:14 2015 -0700
Commit:     Erik Clarizio <eclarizi>
CommitDate: Wed Jul 29 10:16:24 2015 -0700

    Refactor hash struct usage for allowed vms or templates
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1240742

 vmdb/app/models/miq_provision_virt_workflow.rb | 49 ++++++++++++++++----------
 1 file changed, 31 insertions(+), 18 deletions(-)

Comment 9 CFME Bot 2015-07-30 13:21:06 UTC
New commit detected on cfme/5.4.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=2b04b0fe6a4621e7e235f0143f5a77b85a83f529

commit 2b04b0fe6a4621e7e235f0143f5a77b85a83f529
Author:     Erik Clarizio <eclarizi>
AuthorDate: Fri Jul 10 12:55:53 2015 -0700
Commit:     Erik Clarizio <eclarizi>
CommitDate: Wed Jul 29 10:16:24 2015 -0700

    Refactor init_from_dialog method to prevent duplicate loops
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1240742

 vmdb/app/models/miq_request_workflow.rb       | 59 ++++++++++----------
 vmdb/spec/models/miq_request_workflow_spec.rb | 80 +++++++++++++++++++++++++++
 2 files changed, 108 insertions(+), 31 deletions(-)

Comment 10 CFME Bot 2015-07-30 13:21:10 UTC
New commit detected on cfme/5.4.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=b21a01b2be2a687089f3de41e59b31e838a3402a

commit b21a01b2be2a687089f3de41e59b31e838a3402a
Author:     Erik Clarizio <eclarizi>
AuthorDate: Fri Jul 10 14:17:00 2015 -0700
Commit:     Erik Clarizio <eclarizi>
CommitDate: Wed Jul 29 10:16:25 2015 -0700

    Create new method to go through tab list by name
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1240742
    
    This is instead of the old 'get_all_dialogs' or 'get_dialog(name)' as
    those were going through all of the fields even if they didn't need to

 vmdb/app/models/miq_request_workflow.rb       | 18 ++++++++++++++++++
 vmdb/app/views/miq_request/_prov_wf.html.haml | 12 ++++++------
 vmdb/spec/models/miq_request_workflow_spec.rb | 16 ++++++++++++++++
 3 files changed, 40 insertions(+), 6 deletions(-)

Comment 11 CFME Bot 2015-07-30 13:21:13 UTC
New commit detected on cfme/5.4.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=a76e231bf7bd1f5d1d40984b60c205fe8d783d49

commit a76e231bf7bd1f5d1d40984b60c205fe8d783d49
Author:     Erik Clarizio <eclarizi>
AuthorDate: Mon Jul 13 11:51:30 2015 -0700
Commit:     Erik Clarizio <eclarizi>
CommitDate: Wed Jul 29 10:16:25 2015 -0700

    Address some Rubocop issues
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1240742

 vmdb/app/models/miq_request_workflow.rb       | 22 +++++++++++++---------
 vmdb/spec/models/miq_request_workflow_spec.rb |  2 +-
 2 files changed, 14 insertions(+), 10 deletions(-)

Comment 12 CFME Bot 2015-07-30 13:21:17 UTC
New commit detected on cfme/5.4.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=e2c0029617ced6ad64713145aaeda2f927b6c107

commit e2c0029617ced6ad64713145aaeda2f927b6c107
Author:     Erik Clarizio <eclarizi>
AuthorDate: Thu Jul 16 14:38:56 2015 -0700
Commit:     Erik Clarizio <eclarizi>
CommitDate: Wed Jul 29 15:18:45 2015 -0700

    Add condition in #init_from_dialog to prevent overwriting existing values
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1240742

 vmdb/app/models/miq_request_workflow.rb       | 1 +
 vmdb/spec/models/miq_request_workflow_spec.rb | 9 +++++++++
 2 files changed, 10 insertions(+)

Comment 17 errata-xmlrpc 2015-12-08 13:22:10 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2015:2551