Bug 1241059
| Summary: | Could not execute new_sources: unsupported second type in tuple | ||
|---|---|---|---|
| Product: | [Fedora] Fedora EPEL | Reporter: | Pavol Babinčák <pbabinca> |
| Component: | rpkg | Assignee: | Dennis Gilmore <dennis> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | epel7 | CC: | araszka, dennis, drjohnson1, lsedlar, mcepl, mcepl, mgoldman, orion, pbabinca, s |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | rpkg-1.47-7.fc25 rpkg-1.47-7.fc24 rpkg-1.47-7.el7 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-01-06 21:49:30 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
This bug appears to have been reported against 'rawhide' during the Fedora 23 development cycle. Changing version to '23'. (As we did not run this process for some time, it could affect also pre-Fedora 23 development cycle bugs. We are very sorry. It will help us with cleanup during Fedora 23 End Of Life. Thank you.) More information and reason for this action is here: https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora23 Pull-request: https://pagure.io/rpkg/pull-request/17 The main issue here is that GitPython in some version returns unicode instead of str. The best fix here is to check the returned value and encode it if necessary. The place to do this is in pyrpkg/__init__.py in method load_push_url. rpkg-1.47-6.fc25 fedpkg-1.26-4.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-730ed750f8 fedpkg-1.26-4.fc24 rpkg-1.47-6.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-1146121922 fedpkg-1.26-4.el7 rpkg-1.47-6.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-14415f0f51 fedpkg-1.26-4.el7 rpkg-1.47-6.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-14415f0f51 fedpkg-1.26-4.el7, rpkg-1.47-6.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-14415f0f51 fedpkg-1.26-4.fc25, rpkg-1.47-6.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-730ed750f8 fedpkg-1.26-4.el7 rpkg-1.47-7.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-14415f0f51 fedpkg-1.26-4.fc25 rpkg-1.47-7.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-730ed750f8 fedpkg-1.26-4.fc24, rpkg-1.47-6.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-1146121922 fedpkg-1.26-4.el7, rpkg-1.47-7.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-14415f0f51 fedpkg-1.26-4.fc25, rpkg-1.47-7.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-730ed750f8 fedpkg-1.26-4.fc25, rpkg-1.47-7.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. fedpkg-1.26-4.fc24 rpkg-1.47-7.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-1146121922 fedpkg-1.26-4.fc24, rpkg-1.47-7.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-1146121922 new-sources is working, but import still isn't: Could not execute import_srpm: unsupported second type in tuple File a new bug? rpkg is not listed as a dep for fedpkg. without rpkg installed, it looks like this: $ fedpkg new-sources foo-2.0.29.tar.gz Could not execute new_sources: unsupported second type in tuple $ fedpkg import foo-2.0.29-1.fc26.src.rpm Could not execute import_srpm: unsupported second type in tuple Fix / Hack: $ sudo yum install rpkg --enablerepo=epel-testing Results: $ fedpkg new-sources foo-2.0.29.tar.gz Uploading: foo-2.0.29.tar.gz ######################################################################## 100.0% Source upload succeeded. Don't forget to commit the sources file Looks like fedpkg really should have a "Requires: rpkg > 1.46" in the .spec. Fedpkg does not depend on rpkg. It only needs pyrpkg library, which is a subpackage of rpkg. You should never need the rpkg package. However, you are right that in this case fedpkg should probably have a constraint to pull in the latest version of pyrpkg. fedpkg-1.26-4.fc24, rpkg-1.47-7.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. fedpkg-1.26-4.el7, rpkg-1.47-7.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. |
Description of problem: If pyrpkg client (rhpkg in this case) is run on RHEL 7 machine new-sources command (sometimes?) fails with unsupported second type in tuple error. Version-Release number of selected component (if applicable): rpkg-1.35-2.el7 python-pycurl-7.19.0-17.el7 How reproducible: ? Steps to Reproduce: 1. rhpkg co $REPO 2. cd ./$REPO 3. rhpkg switch-branch $BRANCH 4. rhpkg new-sources $TARBALL Actual results: Last command fails with error: TypeError: unsupported second type in tuple Expected results: Upload should start and succeed. Additional info: Branch doesn't contain spec file (yet). With pdb we found out that one of the values is unicode: $ python -m pdb $(which rhpkg) -d new-sources $TARBALL (Pdb) r (Pdb) cont (Pdb) post_data [('name', u'foo'), ('md5sum', '8504338b05521750769df21185d0cd9b'), ('filename', 'tarball.zip')] (where REPO='foo' and TARBALL='tarball.zip') The problem seems to be that RHEL 7 is distributed with pycurl which doesn't fully support unicode: http://pycurl.sourceforge.net/doc/unicode.html#legacy-pycurl-versions Encoding to utf-8 on a right place should fix the issue. There is a workaround - explicitly specify name of the repository: rhpkg --module-name $REPO new-sources $TARBALL