Bug 1241066

Summary: could not convert '{{.... }}' from '<brace-enclosed initializer list>' to 'CvScalar' with opencv3
Product: [Fedora] Fedora Reporter: Jozef Mlich <jmlich>
Component: frei0r-pluginsAssignee: Nicolas Chauvet (kwizart) <kwizart>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 23CC: hhorak, kwizart, sergio
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-05-05 23:24:15 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1230078    
Attachments:
Description Flags
compatibility fixes with older std-cpp and opencv
none
frei0r-plugins.spec.patch none

Description Jozef Mlich 2015-07-08 11:38:42 UTC
Created attachment 1049826 [details]
compatibility fixes with older std-cpp and opencv

Description of problem:
We are trying to rebuild dependencies with OpenCV 3.0.0. This package reports following error during the build

filter/facedetect/facedetect.cpp:267:9: error: could not convert '{{cvRound((((FaceDetect*)this)->FaceDetect::color[0].f0r_param_color::r * 2.55e+2f)), cvRound((((FaceDetect*)this)->FaceDetect::color[0].f0r_param_color::g * 2.55e+2f)), cvRound((((FaceDetect*)this)->FaceDetect::color[0].f0r_param_color::b * 2.55e+2f)), cvRound((((FaceDetect*)this)->FaceDetect::alpha * 2.55e+2))}}' from '<brace-enclosed initializer list>' to 'CvScalar'

More detailed description is at 
https://copr-be.cloud.fedoraproject.org/results/sergiomb/opencv/fedora-22-x86_64/frei0r-plugins-1.4-3.fc22/build.log.gz

In attachment is patch which should fix those problems. I would like to ask you for its review. 

I have done build with this patch in copr repository:
https://copr.fedoraproject.org/coprs/sergiomb/opencv/build/102905/

Unfortunatelly, I wasn't able to create an account in upstream trac.
http://www.piksel.no/projects/frei0r/report

Comment 1 Jan Kurik 2015-07-15 13:20:22 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 23 development cycle.
Changing version to '23'.

(As we did not run this process for some time, it could affect also pre-Fedora 23 development
cycle bugs. We are very sorry. It will help us with cleanup during Fedora 23 End Of Life. Thank you.)

More information and reason for this action is here:
https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora23

Comment 3 Viktor Jancik 2015-08-18 09:49:09 UTC
Record of communication with upstream:

From: Dan Dennedy <dan>
Date: Mon, 17 Aug 2015 19:21:36 +0000
Subject: Re: Frei0r bug tracker issue
To: Viktor Jancik <vjancik>

On Mon, Aug 17, 2015 at 5:55 AM Viktor Jancik <vjancik> wrote:

> Hi,
>
> I was looking for frei0r upstream bug tracker and found this website:
> http://www.piksel.no/projects/frei0r/report
>
> However I was unable to figure out how to actually create a ticket.
>
>
frei0r is a strange, hardly maintained project. The project's web presence,
mailing list, and main git repo have moved to dyne.org; but piksel.no has
not taken anything down even though the one person at piksel.no have done
nothing on the project for years. I guess the main way to report bugs now
is the mailist list despite no real tracking.


> There is bug filed for frei0r-plugins in our bugzilla, and a proposed
> patch is attached:
> https://bugzilla.redhat.com/show_bug.cgi?id=1241066
>
> The summary is that we are upgrading OpenCV to version 3 in Fedora and
> frei0r-plugins gets broken by it.
>
> Could you please review the patch and get back to me if you merge it in or
> if there are some mistakes in it?
>
>
I will try to merge it within 48 hours.


> Thank you very much,
> Viktor
>

Comment 4 Sergio Basto 2016-05-04 18:30:53 UTC
Hello , 
frei0r-plugins have a new https://frei0r.dyne.org/ and new source repository https://github.com/ddennedy/frei0r , also we have a new release (1.5), looks like that already have the fixes , I will check ...

Comment 5 Sergio Basto 2016-05-05 02:02:03 UTC
Created attachment 1154069 [details]
frei0r-plugins.spec.patch

This update allows build also with opencv-3.1 , kwizart as I know that your are busy , I'm requesting commit acls to update the package myself.
Thanks.