Bug 1241292 (php-zendframework-zend-diactoros)
| Summary: | Review Request: php-zendframework-zend-diactoros - PSR HTTP Message implementations | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Shawn Iwinski <shawn> | ||||||
| Component: | Package Review | Assignee: | Remi Collet <fedora> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | rawhide | CC: | fedora, package-review | ||||||
| Target Milestone: | --- | Flags: | fedora:
fedora-review+
gwync: fedora-cvs+ |
||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | php-zendframework-zend-diactoros-1.1.2-1.el7 | Doc Type: | Bug Fix | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2015-07-30 01:14:00 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
Shawn Iwinski
2015-07-08 23:08:27 UTC
Created attachment 1052227 [details]
phpci.log
phpCompatInfo version 4.4.0 DB built Jul 13 2015 09:14:16 CEST static analyze results
Created attachment 1052228 [details]
review.txt
Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04
[!]: License field in the package spec file matches the actual license. => BSD (composer says BSD-2-clause, LICENSE looks like BSD-3 but we dont care) -License: MIT +License: BSD [~]: Rpmlint is run on all installed packages. => E: description-line-too-long C proposal -[1] https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-7-http-message.md +[1] http://www.php-fig.org/psr/psr-7/ PErhaps better to use full patch for symfony - require_once 'Symfony/Component/ClassLoader/ClassLoader.php'; + require_once '%{phpdir}/Symfony/Component/ClassLoader/ClassLoader.php'; License is a blocker. Updated to 1.1.2 and addressed review comments. Changes: https://github.com/siwinski/rpms/commit/e8209809d0f42f8ef426271aefb4759180ec2008 Spec URL: https://raw.githubusercontent.com/siwinski/rpms/e8209809d0f42f8ef426271aefb4759180ec2008/php-zendframework-zend-diactoros/php-zendframework-zend-diactoros.spec SRPM URL: https://siwinski.fedorapeople.org/SRPMS/php-zendframework-zend-diactoros-1.1.2-1.fc22.src.rpm [x]: License field in the package spec file matches the actual license. [x]: Rpmlint is run on all installed packages. Blocker fixed. === APPROVED === THANKS for the review! New Package SCM Request ======================= Package Name: php-zendframework-zend-diactoros Short Description: PSR HTTP Message implementations Upstream URL: https://github.com/zendframework/zend-diactoros Owners: siwinski Branches: f21 f22 f23 epel7 InitialCC: Git done (by process-git-requests). php-zendframework-zend-diactoros-1.1.2-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/php-zendframework-zend-diactoros-1.1.2-1.fc21 php-zendframework-zend-diactoros-1.1.2-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/php-zendframework-zend-diactoros-1.1.2-1.fc22 php-zendframework-zend-diactoros-1.1.2-1.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/php-zendframework-zend-diactoros-1.1.2-1.el7 php-zendframework-zend-diactoros-1.1.2-1.el7 has been pushed to the Fedora EPEL 7 testing repository. php-zendframework-zend-diactoros-1.1.2-1.fc22 has been pushed to the Fedora 22 stable repository. php-zendframework-zend-diactoros-1.1.2-1.fc21 has been pushed to the Fedora 21 stable repository. php-zendframework-zend-diactoros-1.1.2-1.el7 has been pushed to the Fedora EPEL 7 stable repository. |