Bug 1241675

Summary: [RFE] Check for missing openshift_application_aliases components f5-icontrol-rest.rb
Product: OpenShift Container Platform Reporter: Ryan Howe <rhowe>
Component: RFEAssignee: Miciah Dashiel Butler Masters <mmasters>
Status: CLOSED ERRATA QA Contact: Johnny Liu <jialiu>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 2.2.0CC: adellape, anli, jokerman, libra-bugs, libra-onpremise-devel, mmccomas, tiwillia
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: rubygem-openshift-origin-routing-daemon-0.26.4.3-1.el6op Doc Type: Enhancement
Doc Text:
Normally, when the routing daemon is configured with F5 BIG-IPĀ®, the routing daemon checks for the `openshift_application_aliases` local traffic policy on startup and creates the policy if it does not exist. However, the routing daemon previously did not validate that any existing policy was configured properly. As a result, if the F5 administrator set up the policy manually and configured it incorrectly, or changed the policy's configuration later, the policy may no longer function properly. This enhancement changes the routing daemon's startup check to include validation of the policy. In particular, the routing daemon now checks that the policy is configured with the `forwarding` control and the `http` aspect, and it updates the policy's configuration if required.
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-12-17 17:10:26 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Ryan Howe 2015-07-09 18:54:28 UTC
If openshift_application_aliases policy that OSE creates failed to add/apply the forwarding Control because of a manual setup of the alias forgot to add forwarding for example there is no code in place to check the alias and it's required components, and update whats missing 

https://github.com/openshift/origin-server/blob/master/routing-daemon/lib/openshift/routing/models/f5-icontrol-rest.rb

Comment 3 openshift-github-bot 2015-10-06 21:52:43 UTC
Commit pushed to master at https://github.com/openshift/origin-server

https://github.com/openshift/origin-server/commit/151d9a913883e5183819448c8e2e121dacf6e949
routing-daemon: F5: Fix policy if broken

OpenShift::F5IControlRestLoadBalancerModel#Initialize: If the policy
exists, make sure it has the "forwarding" control and requires the "http"
aspect, and patch it if it does not.

This commit fixes bug 1241675.

Comment 11 Miciah Dashiel Butler Masters 2015-11-23 23:11:48 UTC
Sorry for the silly error.  The fix will be in the next puddle.

Comment 14 Anping Li 2015-11-25 04:46:17 UTC
Test Steps:
1) clear all pool pin on openshift_application_aliases 
2) remove values for Requires and  Controls in openshift_application_aliases 
3) /etc/init.d/openshift-routing-daemon start

Comment 16 Anping Li 2015-12-04 02:32:00 UTC
Verified and pass on the rubygem-openshift-origin-routing-daemon-0.26.4.4-1.el6op.noarch.rpm

Comment 18 errata-xmlrpc 2015-12-17 17:10:26 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2015-2666.html