Bug 1241890

Summary: undefined method `description' for nil:NilClass] encountered during phase [create_pxe_configuration_file] when no pxe image is selected while provisioning
Product: Red Hat CloudForms Management Engine Reporter: Aziza Karol <akarol>
Component: ProvisioningAssignee: Drew Bomhof <dbomhof>
Status: CLOSED ERRATA QA Contact: Aziza Karol <akarol>
Severity: medium Docs Contact:
Priority: high    
Version: 5.3.0CC: akarol, jhardy, obarenbo, simaishi
Target Milestone: GA   
Target Release: 5.5.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.5.0.11 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-12-08 13:22:16 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Aziza Karol 2015-07-10 10:48:22 UTC 
Description of problem:


Version-Release number of selected component (if applicable):
5.3.5.3.20150708141502_b69b688

How reproducible:
100%

Steps to Reproduce:
1.Do a rhev pxe service provisioning without selecting a image


Actual results:
[[NoMethodError]: undefined method `description' for nil:NilClass] encountered during phase [create_pxe_configuration_file] in evm.log

Expected results:
Validation required if the pxe image is nil

Additional info:
evm.log
sis_5405_hEZHterX] id: [342] location: [f2b09cc7-80a2-4a3d-b8e4-209daa5a6c53.ovf] storage id: [13] uid_ems: [f2b09cc7-80a2-4a3d-b8e4-209daa5a6c53] ems_ref: [/api/vms/f2b09cc7-80a2-4a3d-b8e4-209daa5a6c53]
[----] E, [2015-07-09T08:49:29.877985 #52611:e7480c] ERROR -- : Q-task_id([miq_provision_3]) MIQ(MiqProvisionRedhatViaPxe#provision_error) [[NoMethodError]: undefined method `description' for nil:NilClass] encountered during phase [create_pxe_configuration_file]
[----] E, [2015-07-09T08:49:29.878239 #52611:e7480c] ERROR -- : Q-task_id([miq_provision_3]) /var/www/miq/vmdb/app/models/pxe_server.rb:185:in `create_provisioning_files'
/var/www/miq/vmdb/app/models/miq_provision/pxe.rb:65:in `create_pxe_files'
/var/www/miq/vmdb/app/models/miq_provision_redhat_via_pxe/state_machine.rb:15:in `create_pxe_configuration_file'
/var/www/miq/vmdb/app/models/miq_request_task/state_machine.rb:26:in `signal'
/var/www/miq/vmdb/app/models/miq_provision_redhat_via_pxe/state_machine.rb:8:in `customize_destination'
/var/www/miq/vmdb/app/models/miq_request_task/state_machine.rb:26:in `signal'
/var/www/miq/vmdb/app/models/miq_provision/state_machine.rb:26:in `poll_destination_in_vmdb'
/var/www/miq/vmdb/app/models/miq_queue.rb:361:in `block in deliver'
/opt/rh/ruby193/root/usr/share/ruby/timeout.rb:69:in `timeout'
/var/www/miq/vmdb/app/models/miq_queue.rb:357:in `deliver'
/var/www/miq/vmdb/lib/workers/queue_worker_base.rb:107:in `deliver_queue_message'
/var/www/miq/vmdb/lib/workers/queue_worker_base.rb:135:in `deliver_message'
/var/www/miq/vmdb/lib/workers/queue_worker_base.rb:152:in `block in do_work'
/var/www/miq/vmdb/lib/workers/queue_worker_base.rb:146:in `loop'
/var/www/miq/vmdb/lib/workers/queue_worker_base.rb:146:in `do_work'
/var/www/miq/vmdb/lib/workers/worker_base.rb:317:in `block in do_work_loop'
/var/www/miq/vmdb/lib/workers/worker_base.rb:314:in `loop'
/var/www/miq/vmdb/lib/workers/worker_base.rb:314:in `do_work_loop'
/var/www/miq/vmdb/lib/workers/worker_base.rb:135:in `run'
/var/www/miq/vmdb/lib/workers/worker_base.rb:123:in `start'
/var/www/miq/vmdb/lib/workers/worker_base.rb:23:in `start_worker'
/var/www/miq/vmdb/lib/workers/bin/worker.rb:5:in `<top (required)>'
/opt/rh/ruby193/root/usr/share/gems/gems/railties-3.2.17/lib/rails/commands/runner.rb:52:in `eval'
/opt/rh/ruby193/root/usr/share/gems/gems/railties-3.2.17/lib/rails/commands/runner.rb:52:in `<top (required)>'
/opt/rh/ruby193/root/usr/share/gems/gems/railties-3.2.17/lib/rails/commands.rb:64:in `require'
/opt/rh/ruby193/root/usr/share/gems/gems/railties-3.2.17/lib/rails/commands.rb:64:in `<top (required)>'
script/rails:6:in `require'
script/rails:6:in `<main>'
Comment 3 Dave Johnson 2015-07-17 14:54:55 UTC 
Aziza, can you try to reproduce this on 5.4.1 once we get a build, thx!
Comment 4 Aziza Karol 2015-07-21 09:05:46 UTC 
This issue is still reproducible on 5.4.1.

I selected the pxe server but did not select an image while provisioning.
Comment 5 Greg McCullough 2015-11-11 14:45:10 UTC 
Drew - This is the same issue as Bug 1255190 but for PXE provisioning which should also be addressed by the same fix.
Comment 7 Drew Bomhof 2015-11-12 16:25:04 UTC 
(In reply to Drew Bomhof from comment #6)
> https://bugzilla.redhat.com/show_bug.cgi?id=1241890

https://github.com/ManageIQ/manageiq/pull/5395
Comment 8 CFME Bot 2015-11-16 21:18:52 UTC 
New commit detected on cfme/5.5.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=f115304ec432d7cbfe223cc58aa816444d95d9bd

commit f115304ec432d7cbfe223cc58aa816444d95d9bd
Merge: 45ae51e e500133
Author:     Greg McCullough <gmccullo>
AuthorDate: Fri Nov 13 16:50:58 2015 -0500
Commit:     Greg McCullough <gmccullo>
CommitDate: Fri Nov 13 16:50:58 2015 -0500

    Merge branch '5.5.z_iso_image_selection_validation' into '5.5.z'
    
    Validate Iso and Pxe child dialogs
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1255190
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1241890
    
    Refactored how the update_field_required method validates if supports_pxe?
    or supports_iso? are required fields.
    
    Renamed the method to update_field_visibility_pxe_iso
    
    We now simply apply the :edit, or :hide flags to the MiqProvisionVirtDialog class
    which implicitly does not validate on hidden fields
    
    PR:https://github.com/ManageIQ/manageiq/pull/5395
    
    Cherry-Pick was clean
    
    See merge request !431

 app/models/miq_provision_virt_workflow.rb       | 16 ++++++------
 spec/models/miq_provision_virt_workflow_spec.rb | 33 +++++++++++++++++++++++++
 2 files changed, 41 insertions(+), 8 deletions(-)
Comment 9 Aziza Karol 2015-11-19 09:38:13 UTC 
Catalog/Image' is required displayed while creating catalog items.

Verified:
5.5.0.11-rc1.20151117182049_653c0d4
Comment 11 errata-xmlrpc 2015-12-08 13:22:16 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2015:2551