Bug 1241902

Summary: "cannot concatenate 'str' and 'exceptions.ValueError' objects" when creating New VM without valid OS type
Product: [Fedora] Fedora Reporter: Jonathan Wakely <jwakely>
Component: virt-managerAssignee: Cole Robinson <crobinso>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: unspecified    
Version: 22CC: berrange, crobinso, virt-maint
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: virt-manager-1.2.1-2.fc22 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-08-18 05:14:27 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
screenshot none

Description Jonathan Wakely 2015-07-10 11:30:49 UTC
Created attachment 1050654 [details]
screenshot

Description of problem:


Version-Release number of selected component (if applicable):



How reproducible:

Always

Steps to Reproduce:
1. In virt-manager create new VM from local install media, choose path to some ISO
2. Uncheck "Automatically detect operating system based on install media"
3. Choose OS type: UNIX (first select "Show all OS options" then choose "UNIX") pick any version.
4. Check "Automatically detect ..." again
5. Uncheck it again (Version will now be blank)
6. Click "> Forward"

Actual results:

Blank version cause a python exception to be shown with the exceedingly unhelpful message:

  Error setting installer parameters.
  cannot concatenate 'str' and 'exceptions.ValueError' objects


Expected results:

An error with more context, maybe pointing out that Version cannot be left blank. Or alternatively, don't forget the previously selected value for the Version field blank after checking/unchecking the "Automatically detect..." checkbox.

Comment 1 Cole Robinson 2015-08-10 17:05:35 UTC
Thanks for the simple reproducer! Fixed upstream now:

commit cca72a73c496b715bc90ee277291d0cbcf6d1771
Author: Cole Robinson <crobinso>
Date:   Mon Aug 10 12:56:11 2015 -0400

    create: Fix backtrace when reporting OS error (bz 1241902)

Comment 2 Fedora Update System 2015-08-11 20:12:02 UTC
virt-manager-1.2.1-2.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/virt-manager-1.2.1-2.fc22

Comment 3 Fedora Update System 2015-08-13 16:53:55 UTC
Package virt-manager-1.2.1-2.fc22:
* should fix your issue,
* was pushed to the Fedora 22 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing virt-manager-1.2.1-2.fc22'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2015-13390/virt-manager-1.2.1-2.fc22
then log in and leave karma (feedback).

Comment 4 Fedora Update System 2015-08-18 05:14:27 UTC
virt-manager-1.2.1-2.fc22 has been pushed to the Fedora 22 stable repository.  If problems still persist, please make note of it in this bug report.