Bug 1242090

Needed for nodejs-socks-proxy-agent

*** Bug 1258258 has been marked as a duplicate of this bug. ***

LICENSE must be moved to %license.


You can remove the following dependencies:

BuildRequires:      npm(ip)
BuildRequires:      npm(smart-buffer)

Requires:           npm(ip)
Requires:           npm(smart-buffer)

Those are handled automatically by nodejs-packaging scripts from package.json.


npmjs website has functional tls, I suggest changing the Source0 to https:// for security reasons. Don't think this is somewhere in the guidelines but I think it is good practice to use https if available.

Done.

Spec URL: http://threebean.org/rpm/SPECS/nodejs-socks-client.spec
SRPM URL: http://threebean.org/rpm/SRPMS/nodejs-socks-client-1.1.4-2.fc22.src.rpm

There is one error which can be fixed before uploading: description is not wrapped into 80 chars. 

I will approve, could please you add me as co-maintainer? I will build the pkg.




nodejs-socks-client.noarch: E: description-line-too-long C A SOCKS proxy client supporting SOCKS 4, 4a, and 5. (also supports BIND/Associate)


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated". 6 files have unknown license. Detailed
     output of licensecheck in /home/piotr/rpmbuild/1242090-nodejs-socks-
     client/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: nodejs-socks-client-1.1.4-2.fc24.noarch.rpm
          nodejs-socks-client-1.1.4-2.fc24.src.rpm
nodejs-socks-client.noarch: E: description-line-too-long C A SOCKS proxy client supporting SOCKS 4, 4a, and 5. (also supports BIND/Associate)
nodejs-socks-client.noarch: W: only-non-binary-in-usr-lib
nodejs-socks-client.noarch: W: dangling-symlink /usr/lib/node_modules/socks-client/node_modules/ip /usr/lib/node_modules/ip
nodejs-socks-client.noarch: W: dangling-symlink /usr/lib/node_modules/socks-client/node_modules/smart-buffer /usr/lib/node_modules/smart-buffer
nodejs-socks-client.src: E: description-line-too-long C A SOCKS proxy client supporting SOCKS 4, 4a, and 5. (also supports BIND/Associate)
2 packages and 0 specfiles checked; 2 errors, 3 warnings.




Rpmlint (installed packages)
----------------------------
sh: /usr/bin/python: No such file or directory
nodejs-socks-client.noarch: E: description-line-too-long C A SOCKS proxy client supporting SOCKS 4, 4a, and 5. (also supports BIND/Associate)
nodejs-socks-client.noarch: W: only-non-binary-in-usr-lib
nodejs-socks-client.noarch: W: dangling-symlink /usr/lib/node_modules/socks-client/node_modules/smart-buffer /usr/lib/node_modules/smart-buffer
nodejs-socks-client.noarch: W: dangling-symlink /usr/lib/node_modules/socks-client/node_modules/ip /usr/lib/node_modules/ip
1 packages and 0 specfiles checked; 1 errors, 3 warnings.



Requires
--------
nodejs-socks-client (rpmlib, GLIBC filtered):
    nodejs(engine)
    npm(ip)
    npm(smart-buffer)



Provides
--------
nodejs-socks-client:
    nodejs-socks-client
    npm(socks-client)



Source checksums
----------------
https://registry.npmjs.org/socks-client/-/socks-client-1.1.4.tgz :
  CHECKSUM(SHA256) this package     : ce8978f019e7f3d1975361bd2efd06852c6748260e835f64197774bd59391472
  CHECKSUM(SHA256) upstream package : ce8978f019e7f3d1975361bd2efd06852c6748260e835f64197774bd59391472


Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
Command line :/usr/bin/fedora-review -b 1242090
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

New Package SCM Request
=======================
Package Name: nodejs-socks-client
Short Description: A SOCKS proxy client supporting SOCKS 4, 4a, and 5
Upstream URL: https://npmjs.org/package/socks-client
Owners: ralph piotrp
Branches: f23 f22 f21 epel7
InitialCC:

Git done (by process-git-requests).

nodejs-socks-client-1.1.4-3.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-14695

nodejs-socks-client-1.1.4-3.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-14696

nodejs-socks-client-1.1.4-3.fc21 has been submitted as an update to Fedora 21. https://bodhi.fedoraproject.org/updates/FEDORA-2015-14697

Built in rawhide, closing

nodejs-socks-client-1.1.4-3.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update nodejs-socks-client'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-14696

nodejs-socks-client-1.1.4-3.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update nodejs-socks-client'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-14695

nodejs-socks-client-1.1.4-3.fc21 has been pushed to the Fedora 21 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update nodejs-socks-client'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-14697

nodejs-socks-client-1.1.4-3.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.

nodejs-socks-client-1.1.4-3.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report.

nodejs-socks-client-1.1.4-3.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.