Bug 1242211

Summary:	libglusterfs: Pending - Porting log messages to new framework
Product:	[Red Hat Storage] Red Hat Gluster Storage	Reporter:	SATHEESARAN <sasundar>
Component:	core	Assignee:	Mohamed Ashiq <mliyazud>
Status:	CLOSED WONTFIX	QA Contact:	Anoop <annair>
Severity:	high	Docs Contact:
Priority:	low
Version:	rhgs-3.1	CC:	atumball, mliyazud, rhs-bugs
Target Milestone:	---	Keywords:	ZStream
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	1252836 (view as bug list)		Environment:
Last Closed:	2018-02-01 05:14:49 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1252836, 1258769

Description SATHEESARAN 2015-07-12 10:24:47 UTC

Description of problem:
-----------------------
There are few instances of 'gf_log' and 'gf_log_callingfn' seen under libglusterfs
These instances needs to be ported to new logging framework

Version-Release number of selected component (if applicable):
-------------------------------------------------------------
RHGS-3.1 Nightly ( glusterfs-3.7.1-8.el6rhs )


Expected results:
-----------------
All old log messages should be ported to new logging framework

Comment 1 SATHEESARAN 2015-07-12 17:18:07 UTC

src/inode.c:  gf_log_callingfn (THIS->name, GF_LOG_WARNING,
src/inode.c-        "inode not found");

[satheesaran@dhcppc1 libglusterfs]$ grep -r "gf_log " src/logging.h -B1 -A1

int _gf_log (const char *domain, const char *file,
             const char *function, int32_t line, gf_loglevel_t level,
--
                FMT_WARN (fmt);                                         \
                _gf_log (dom, __FILE__, __FUNCTION__, __LINE__,         \
                         levl, ##fmt);                                  \
--
#define GF_LOG_OCCASIONALLY(var, args...) if (!(var++%GF_UNIVERSAL_ANSWER)) { \
                gf_log (args);                                          \
        }
--
#define GF_DEBUG(xl, format, args...)                           \
        gf_log ((xl)->name, GF_LOG_DEBUG, format, ##args)
#define GF_INFO(xl, format, args...)                            \
        gf_log ((xl)->name, GF_LOG_INFO, format, ##args)
#define GF_WARNING(xl, format, args...)                         \
        gf_log ((xl)->name, GF_LOG_WARNING, format, ##args)
#define GF_ERROR(xl, format, args...)                           \
        gf_log ((xl)->name, GF_LOG_ERROR, format, ##args)


--
src/xlator.c:  gf_log ("glusterfs", gf_log_get_loglevel(),
src/xlator.c-       "setting log level to %d (old-value=%d)",
--
src/xlator.c:  gf_log (this->name, gf_log_get_xl_loglevel (this),
src/xlator.c-        "setting log level to %d (old-value=%d)",
--
src/xlator.c:  gf_log (trav->name, gf_log_get_xl_loglevel (trav),
src/xlator.c-        "setting log level to %d (old-value=%d)",

src/unittest/log_mock.c:int _gf_log (const char *domain, const char *file,
src/unittest/log_mock.c-             const char *function, int32_t line, gf_loglevel_t level,

--
src/run.c:  gf_log_callingfn (dom, lvl, "%s: %s", msg, buf);
src/run.c-
--
src/timespec.c:        gf_log_callingfn ("timer", GF_LOG_TRACE, "%"GF_PRI_TIME".%09"GF_PRI_TIME,
src/timespec.c-                          ts->tv_sec, ts->tv_nsec);

Comment 2 Mohamed Ashiq 2015-09-01 10:52:30 UTC

The patch is:
https://code.engineering.redhat.com/gerrit/56785

Comment 3 Mohamed Ashiq 2015-09-01 10:53:10 UTC

The patch is:
https://code.engineering.redhat.com/gerrit/56785

Comment 4 Mike McCune 2016-03-28 23:07:19 UTC

This bug was accidentally moved from POST to MODIFIED via an error in automation, please see mmccune with any questions

Comment 5 Amar Tumballi 2018-02-01 05:14:49 UTC

The conversion of gf_log() to gf_msg() is an on-going process in the glusterfs project, and would always be some instance of gf_log in the codebase.

We have fixed all the critical path error messages to gf_msg (with an id). Hence closing the bug as WONTFIX (is, git grep would still give some outputs)