Bug 1242280

Summary:	Handle all errors equal in dict_set_bin()
Product:	[Community] GlusterFS	Reporter:	Niels de Vos <ndevos>
Component:	core	Assignee:	Niels de Vos <ndevos>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	medium	Docs Contact:
Priority:	medium
Version:	mainline	CC:	bugs
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.8rc2	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-06-16 13:22:53 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Niels de Vos 2015-07-12 21:33:52 UTC

Description of problem:
Depending on where an error in dict_set_bin() happens, the pointer passed to the function is getting free'd. Some parts of the Gluster code that call dict_set_bin() handle the free'ing themselves, other parts don't. There is no correct way of doing this, because dict_set_bin() itself is broken.

Callers of dict_set_bin() should be responsible for cleanup in case dict_set_bin() fails.

Comment 1 Anand Avati 2015-07-12 21:35:03 UTC

REVIEW: http://review.gluster.org/11638 (dict: dict_set_bin() should never free the pointer on error) posted (#2) for review on master by Niels de Vos (ndevos)

Comment 2 Anand Avati 2015-07-13 09:25:19 UTC

REVIEW: http://review.gluster.org/11638 (dict: dict_set_bin() should never free the pointer on error) posted (#3) for review on master by Niels de Vos (ndevos)

Comment 3 Anand Avati 2015-07-18 11:17:11 UTC

REVIEW: http://review.gluster.org/11638 (dict: dict_set_bin() should never free the pointer on error) posted (#4) for review on master by Niels de Vos (ndevos)

Comment 4 Niels de Vos 2016-06-16 13:22:53 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user