Bug 1242767

Summary:	SMB: share entry from smb.conf is not removed after setting user.cifs and user.smb to disable.
Product:	[Red Hat Storage] Red Hat Gluster Storage	Reporter:	surabhi <sbhaloth>
Component:	samba	Assignee:	Raghavendra Talur <rtalur>
Status:	CLOSED ERRATA	QA Contact:	surabhi <sbhaloth>
Severity:	high	Docs Contact:
Priority:	high
Version:	rhgs-3.1	CC:	annair, asrivast, kparthas, nlevinki, rtalur, vagarwal
Target Milestone:	---	Keywords:	Regression
Target Release:	RHGS 3.1.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.7.1-10	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	1242892 (view as bug list)		Environment:
Last Closed:	2015-07-29 05:12:24 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1242892, 1243041
Bug Blocks:	1202842

Description surabhi 2015-07-14 07:26:05 UTC

Description of problem:
********************************************
Setting user.smb and user.cifs to disable doesn't remove the samba share from smb.conf.

when volume is stopped and started then only the share goes off from smb.conf.


Version-Release number of selected component (if applicable):

rpm -qa | grep glusterfs
glusterfs-client-xlators-3.7.1-9.el7rhgs.x86_64
glusterfs-cli-3.7.1-9.el7rhgs.x86_64
glusterfs-libs-3.7.1-9.el7rhgs.x86_64
glusterfs-3.7.1-9.el7rhgs.x86_64
glusterfs-fuse-3.7.1-9.el7rhgs.x86_64
glusterfs-server-3.7.1-9.el7rhgs.x86_64
samba-vfs-glusterfs-4.1.17-13.el7rhgs.x86_64

How reproducible:
always

Steps to Reproduce:
1.create a volume
2.Start the volume
3.Set the user.cifs and user.smb to disable
4.check the output from testparm
5.Share entry for the volume should be removed.

Actual results:
share is still present in smb.conf and is ready for access.

Expected results:
share entry should be removed and the share should not be ready for access if user.cifs and user.smb is disabled.

Additional info:

Comment 3 Raghavendra Talur 2015-07-14 18:22:25 UTC

Patch posted at https://code.engineering.redhat.com/gerrit/#/c/52988/

Comment 6 surabhi 2015-07-16 12:15:02 UTC

Verified the bug with following steps on new build:

1. Create a volume 
2. start a volume
3. Check the share in smb.conf
4. now set the volume option user.cifs disable , check testparm and smb.conf entries
5.Share should not be present in smb.conf once the option is disable.

Also verified with setting user.cifs and user.smb enable 
user.cifs and user.cifs disable
user.cifs enable and user.smb disable
user.cifs disable and user.smb enable

All above cases works fine.Moving the bz to verified.
glusterfs-3.7.1-10

Comment 7 errata-xmlrpc 2015-07-29 05:12:24 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2015-1495.html