Bug 1242892

Summary: SMB: share entry from smb.conf is not removed after setting user.cifs and user.smb to disable.
Product: [Community] GlusterFS Reporter: Raghavendra Talur <rtalur>
Component: gluster-smbAssignee: Raghavendra Talur <rtalur>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: high Docs Contact:
Priority: high    
Version: mainlineCC: asrivast, bugs, nlevinki, rhs-smb, rkavunga, rtalur, sankarshan, sbhaloth, storage-qa-internal
Target Milestone: ---Keywords: Triaged
Target Release: ---   
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: glusterfs-3.8rc2 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 1242767
: 1243041 (view as bug list) Environment:
Last Closed: 2016-06-16 13:23:25 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1242767, 1243041    

Description Raghavendra Talur 2015-07-14 10:58:27 UTC
Description of problem:
********************************************
Setting user.smb and user.cifs to disable doesn't remove the samba share from smb.conf.

How reproducible:
always

Steps to Reproduce:
1.create a volume
2.Start the volume
3.Set the user.cifs and user.smb to disable
4.check the output from testparm or check smb.conf
5.Share entry for the volume should be removed.

Actual results:
share is still present in smb.conf and is ready for access.

Expected results:
share entry should be removed and the share should not be ready for access if user.cifs and user.smb is disabled.

Comment 1 Anand Avati 2015-07-14 12:49:33 UTC
REVIEW: http://review.gluster.org/11664 (extras/hooks: Fix option parsing for S30samba-set.sh) posted (#1) for review on master by Raghavendra Talur (rtalur)

Comment 2 Anand Avati 2015-07-14 12:52:39 UTC
REVIEW: http://review.gluster.org/11664 (extras/hooks: Fix option parsing for S30samba-set.sh) posted (#2) for review on master by Raghavendra Talur (rtalur)

Comment 3 Anand Avati 2015-07-14 12:52:56 UTC
REVIEW: http://review.gluster.org/11664 (extras/hooks: Fix option parsing for S30samba-set.sh) posted (#3) for review on master by Raghavendra Talur (rtalur)

Comment 4 Anand Avati 2015-07-14 15:32:14 UTC
REVIEW: http://review.gluster.org/11667 (extras/hooks: Fix option parsing for S30samba-set.sh) posted (#1) for review on release-3.7 by Raghavendra Talur (rtalur)

Comment 5 Anand Avati 2015-07-14 17:56:42 UTC
REVIEW: http://review.gluster.org/11668 (extras/hooks: Fix parsing of args in S30samba-set.sh) posted (#1) for review on master by Raghavendra Talur (rtalur)

Comment 6 Vijay Bellur 2015-10-27 12:34:01 UTC
REVIEW: http://review.gluster.org/11668 (extras/hooks: Fix parsing of args in S30samba-set.sh) posted (#2) for review on master by Raghavendra Talur (rtalur)

Comment 7 Vijay Bellur 2015-11-02 11:16:08 UTC
REVIEW: http://review.gluster.org/11668 (extras/hooks: Fix parsing of args in S30samba-set.sh) posted (#3) for review on master by Raghavendra Talur (rtalur)

Comment 8 Vijay Bellur 2015-11-02 15:08:47 UTC
REVIEW: http://review.gluster.org/11668 (extras/hooks: Fix parsing of args in S30samba-set.sh) posted (#4) for review on master by Raghavendra Talur (rtalur)

Comment 9 Vijay Bellur 2015-11-16 07:36:55 UTC
REVIEW: http://review.gluster.org/11668 (extras/hooks: Fix parsing of args in S30samba-set.sh) posted (#6) for review on master by Raghavendra Talur (rtalur)

Comment 10 Vijay Bellur 2015-11-16 13:41:24 UTC
COMMIT: http://review.gluster.org/11668 committed in master by Jeff Darcy (jdarcy) 
------
commit ea7e34f38c97b471fee863fa749e1f0389c4b563
Author: Raghavendra Talur <rtalur>
Date:   Tue Jul 14 23:24:55 2015 +0530

    extras/hooks: Fix parsing of args in S30samba-set.sh
    
    Change-Id: I75756f44757a144b0ed229fcc0e29a273fc75886
    BUG: 1242892
    Signed-off-by: Raghavendra Talur <rtalur>
    Reviewed-on: http://review.gluster.org/11668
    Tested-by: NetBSD Build System <jenkins.org>
    Reviewed-by: Niels de Vos <ndevos>

Comment 11 Niels de Vos 2016-06-16 13:23:25 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user