Bug 1243598

master: https://github.com/droolsjbpm/jbpm-designer/commit/085a65545
6.3.x: https://github.com/droolsjbpm/jbpm-designer/commit/0a70129da
6.2.x: https://github.com/droolsjbpm/jbpm-designer/commit/0ca8936213b75071eae5253e98d84036d0e0613f

This is possible now for following elements: 

Gateways
Lanes
Subprocesses
Events
Data Objects
Data Stores
Text Annotations
callActivities

Updates for commits (6.2.x branches):

jbpm: https://github.com/droolsjbpm/jbpm/commit/ca172a339
jbpm-designer: https://github.com/droolsjbpm/jbpm-designer/commit/778c561d5

Hi, I have to return this ticket because the merge conflict on 6.2.x branch wasn't resolved correctly and some unrelated changes were included.

For example https://github.com/droolsjbpm/jbpm-designer/commit/0ca8936213b75071eae5253e98d84036d0e0613f#commitcomment-13002949. Due to this change, old color attributes are ignored and so when opening a BPMN2 process created in 6.1.2 or older, no colors are displayed. This is a regression.

Please revisit the commit on 6.2.x branch carefully, there may be many more unrelated changes.

Hi,

product version have no Data Objects and Data Stores so it is not tested. For another component you can add the name with line breaks through properties. If you will double-click on element it will remove all line breaks from it name.

See: 
https://bugzilla.redhat.com/show_bug.cgi?id=1258980
https://bugzilla.redhat.com/show_bug.cgi?id=1233981

For colors the older definitions still the default colors should be applied. There is no backwards compatibility to older colors as we started using a bpmn2 color standard which should be used moving forward instead of the custom attributes we had earlier.

The color change allows users to be compatible between editors that use bpmncolor standard.

(In reply to Kirill Gaevskii from comment #6)
> Hi,
> 
> product version have no Data Objects and Data Stores so it is not tested.
> For another component you can add the name with line breaks through
> properties. If you will double-click on element it will remove all line
> breaks from it name.
> 
> See: 
> https://bugzilla.redhat.com/show_bug.cgi?id=1258980
> https://bugzilla.redhat.com/show_bug.cgi?id=1233981

Yes, as stated in the original BZ for these changes from the last patch release to add multiline names users have to use the "name" property from the properties menu on the right.

(In reply to Tihomir Surdilovic from comment #7)
> For colors the older definitions still the default colors should be applied.
> There is no backwards compatibility to older colors as we started using a
> bpmn2 color standard which should be used moving forward instead of the
> custom attributes we had earlier.

If I understand it correctly this is a move towards being more standards-aligned. This is good and I also understand that changes breaking backward compatibility are acceptable under certain conditions. It would probably be OK to drop the old drools-namespaced attributes in the next minor release (6.x) but if this change was not specifically requested by users I would rather not included in this 6.1.x patch update.

I understand. At this point it would be easier to add the backwards compat than remove the standards impl. I will do that and as users save the process they will get the updated bpmn2 which includes the standard. WDYT?

Does that mean the bunch of additional changes on 6.2.x (compared to original fix on master) are not a result of bad merge but were included intentionally because they were somehow necessary for the backport?

If so, can you please confirm that the change of color attributes is the only side effect? Or do we need to watch out for other changes in behaviour? Your answer would be helpful because we got parse error of the process attached to bug 1242410 but validation of the same process in 6.1.2 (previous patch) has no errors(*) so I suspected this to be perhaps something that had broken with the "bad merge".

(*) These are not regular validation issues but a parsing error that prevents getting validation results, accessing node properties and making changes on canvas.

We did have an issue with moving only the needed code over because we did large changes to many parts of the round-tripping json-to-bpmn2 in between the last and this patch releases. I think definitely look out for any possible issues and report so we can fix asap.
Thank you!

6.2.x commit for backwards compat on colors:
https://github.com/droolsjbpm/jbpm-designer/commit/bd158a8098b6b05fa82d3006337f48acf81ed128

Colors backward compatibility added.