Bug 1243946

Summary: RFE: posix: xattrop 'GF_XATTROP_ADD_DEF_ARRAY' implementation
Product: [Community] GlusterFS Reporter: Vijaikumar Mallikarjuna <vmallika>
Component: quotaAssignee: Manikandan <mselvaga>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: mainlineCC: bugs, smohan
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: glusterfs-3.8rc2 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1266882 (view as bug list) Environment:
Last Closed: 2016-06-16 13:24:44 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1266882    

Description Vijaikumar Mallikarjuna 2015-07-16 16:17:10 UTC
implementation of xattrop type
GF_XATTROP_ADD_DEF_ARRAY
GF_XATTROP_ADD_DEF_ARRAY64

These operations are similar to 'GF_XATTROP_ADD_ARRAY',
except that it adds a default value if xattr is missing
or its value is zero on disk.

One use-case of this operation is in inode-quota.
When a new directory is created, its default dir_count
should be set to 1. So when a xattrop performed setting
inode-xattrs, it should account initial dir_count
1 if the xattrs are not present

Here is the usage of this operation

value required in xdata for each key 
struct array {
    int32_t   newvalue_1;
    int32_t   default_1;
    int32_t   newvalue_2;
    int32_t   default_2;
    ... 
    int32_t   newvalue_n;
    int32_t   default_n;
};

xattrop GF_XATTROP_ADD_ARRAY
for i from 1 to n
{
    if (xattr (dest_i) is zero or not set in the disk)
        dest_i = dest_i + newvalue_i + default_i
    else
        dest_i = dest_i + newvalue_i
}

value in xdata after xattrop is successful
struct array {
    int32_t   dest_1;
    int32_t   dest_2;
    ...
    int32_t   dest_n;
};

Comment 1 Anand Avati 2015-07-16 16:31:07 UTC
REVIEW: http://review.gluster.org/11702 (posix: xattrop 'GF_XATTROP_ADD_DEF_ARRAY' implementation) posted (#1) for review on master by Vijaikumar Mallikarjuna (vmallika)

Comment 2 Anand Avati 2015-07-16 16:36:30 UTC
REVIEW: http://review.gluster.org/11702 (posix: xattrop 'GF_XATTROP_ADD_DEF_ARRAY' implementation) posted (#2) for review on master by Vijaikumar Mallikarjuna (vmallika)

Comment 3 Anand Avati 2015-08-20 09:53:34 UTC
REVIEW: http://review.gluster.org/11702 (posix: xattrop 'GF_XATTROP_ADD_ARRAY_WITH_DEFAULT' implementation) posted (#3) for review on master by Vijaikumar Mallikarjuna (vmallika)

Comment 6 Niels de Vos 2016-06-16 13:24:44 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user