Bug 1243969

Summary: Text Annotation connector gets distorted after saving/re-opening a process in BPM Suite 6.1
Product: [Retired] JBoss BPMS Platform 6 Reporter: Amana <ajuricic>
Component: jBPM DesignerAssignee: Tihomir Surdilovic <tsurdilo>
Status: CLOSED EOL QA Contact: Jozef Marko <jomarko>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 6.1.0CC: ajuricic, etirelli, lpetrovi
Target Milestone: ER4   
Target Release: 6.2.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1243989 (view as bug list) Environment:
Last Closed: 2020-03-27 19:04:27 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1243989    
Attachments:
Description Flags
text_annotation_before
none
text_annotation_after
none
6.2.0.ER1 before save
none
6.2.0.ER1 after save none

Description Amana 2015-07-16 17:42:54 UTC
Description of problem:
Text Annotation connector gets distorted after saving/re-opening a process in BPM Suite 6.1. See pictures attached.

Version-Release number of selected component (if applicable):
BPM Suite 6.1

How reproducible:
Always

Steps to Reproduce:
1. Create a simple process and add a Text Annotation to any component;
2. Save the process and close;
3. Open it again.

Actual results:
Connector will get distorted and will point to the center of the text annotation.

Expected results:
It should keep aligned.

Comment 1 Amana 2015-07-16 17:43:39 UTC
Created attachment 1052787 [details]
text_annotation_before

Comment 2 Amana 2015-07-16 17:44:25 UTC
Created attachment 1052788 [details]
text_annotation_after

Comment 4 Tihomir Surdilovic 2015-08-04 16:07:31 UTC
master commit https://github.com/droolsjbpm/jbpm-designer/commit/639fccd42

Comment 6 Jozef Marko 2015-08-31 13:08:40 UTC
Created attachment 1068642 [details]
6.2.0.ER1 before save

Comment 7 Jozef Marko 2015-08-31 13:09:33 UTC
Created attachment 1068643 [details]
6.2.0.ER1 after save

Comment 8 Jozef Marko 2015-08-31 13:11:28 UTC
Reopening this issue. Still reproducible on 6.2.0.ER1. See last two attachments.

Comment 9 Tihomir Surdilovic 2015-08-31 15:49:13 UTC
I cannot reproduce the fix not being done. Can you clear cashe and retest please?

For me it looks correctly: http://i.imgur.com/owmCSjq.png

The 6.2.x commit for this is: https://github.com/droolsjbpm/jbpm-designer/commit/464c43ad00c965fd71242d5bc13644dd55ccbf74

Comment 10 Amana 2015-08-31 16:13:13 UTC
I believe it should be re-tested by QA, right?

Comment 11 Edson Tirelli 2015-08-31 16:36:33 UTC
Tihomir, 6.2.0.ER1 is the product build based on community 6.3.0.CR1. If the fix was committed to the 6.3.x branch after the 6.3.0.CR1 release, then it is not included in the ER1 build being tested.

If that is the case, please let QA know and set this ticket to MODIFIED again for re-test on 6.2.0.ER2 build.

QA team, please retest if it is the case.

Comment 12 Jozef Marko 2015-09-01 06:40:19 UTC
I checked 6.2.0 ER1 build details here [1]. Designer was built from [2]. I cloned this tag and I have not found mentioned commit. Probably this is problem.

Note that in 6.1.3 CR1 is fix included.

[1]
http://dev138.mw.lab.eng.bos.redhat.com/candidate/bpmsuite-6.2.0.ER1/brms.cfg

[2]
https://code.engineering.redhat.com/gerrit/droolsjbpm-jbpm-designer.git#sync-6.3.x-2015.08.11

Comment 13 Lukáš Petrovický 2015-09-01 07:36:10 UTC
(In reply to Jozef Marko from comment #12)
> I checked 6.2.0 ER1 build details here [1]. Designer was built from [2]. I
> cloned this tag and I have not found mentioned commit. Probably this is
> problem.

Jozef, the fix is here, landed on August 4:
https://github.com/droolsjbpm/jbpm-designer/commit/574cde3658c15a9132497d9b9d116855f346e584

> https://code.engineering.redhat.com/gerrit/droolsjbpm-jbpm-designer.git#sync-
> 6.3.x-2015.08.11

However, the fix really is not present here. Weird. 

Edson, do we have a merging problem?

Comment 14 Edson Tirelli 2015-09-01 12:32:02 UTC
Lukas, I think this is a case where the tag was cut before the commit was made. The last commit I see on that tag for jbpm designer is July 31st. 

I don't believe this was a merge problem.

Can we re-test this on ER2/ER3?

Comment 15 Lukáš Petrovický 2015-09-01 12:52:35 UTC
(In reply to Edson Tirelli from comment #14)
> Can we re-test this on ER2/ER3?

Sure.

Comment 16 Jozef Marko 2015-10-19 19:37:08 UTC
Verified on 6.2.0.ER4

Connector keeps the same path after closing and reopening.