Bug 1244510

- Remove %%py3dir macro
- Add CFLAGS in %%build

Spec URL: http://jenselme.perso.centrale-marseille.fr/visible/SPECS/python-txaio.spec
SRPM URL: http://jenselme.perso.centrale-marseille.fr/visible/SRPMS/python-txaio-1.0.0-1.fc22.src.rpm

The comments about Provides:python2-..., separate build dirs, and _docdir_fmt from #1244514 also apply here. (I didn't test that build works with a single source directory, but I'll assume so until proven otherwise.)

If you remove _sources, you'll get dangling symlinks in the documentation. I think it would be better to keep them, it's just a few kilobytes.

Instead of patching jquery, unbundle it: replace the file with a symlink to /usr/share/javascript/jquery/latest/jquery.min.js.

Consider using %autosetup instead of %setup + %patch0.

- Add provides for python2-txaio
- Remove usage of python2 and python3 dirs
- Unbundle jquery
- Don't remove _sources of documentation

I won't use %autosetup as I had problem with line endings when I tried to use it on this package.

SPEC: http://jenselme.perso.centrale-marseille.fr/visible/SPECS/python-txaio.spec
SRPM: http://jenselme.perso.centrale-marseille.fr/visible/SRPMS/python-txaio-1.0.0-3.fc22.src.rpm

(In reply to Julien Enselme from comment #3)
> I won't use %autosetup as I had problem with line endings when I tried to
> use it on this package.
I think it has a bug where you have to insert a blank line after the macro in the spec file. I think that bug was fixed at some point, and is only present in stable fedora branches.

> - Add provides for python2-txaio
> - Remove usage of python2 and python3 dirs
> - Unbundle jquery
You will need Requires: js-jquery in the -doc subpackage.

> - Don't remove _sources of documentation
> 
> 
> SPEC:
> http://jenselme.perso.centrale-marseille.fr/visible/SPECS/python-txaio.spec
> SRPM:
> http://jenselme.perso.centrale-marseille.fr/visible/SRPMS/python-txaio-1.0.0-
> 3.fc22.src.rpm

- license is OK (MIT)
- latest version is packaged
- fs layout is OK
- spec file is nice and clean
- license file is present and %license macro is used
- egg info handling is OK
- rpmlint contains only false positives
- Requires and Provides almost OK, see ISSUES below

Rpmlint:
python-txaio.noarch: W: spelling-error Summary(en_US) asyncio -> Asuncion
python-txaio.noarch: W: spelling-error %description -l en_US asyncio -> Asuncion
python3-txaio.noarch: W: spelling-error Summary(en_US) asyncio -> Asuncion
python3-txaio.noarch: W: spelling-error %description -l en_US asyncio -> Asuncion
python-txaio-doc.noarch: W: spelling-error %description -l en_US asyncio -> Asuncion
python-txaio-doc.noarch: W: file-not-utf8 /usr/share/doc/python-txaio-doc/html/objects.inv
python-txaio-doc.noarch: W: dangling-symlink /usr/share/doc/python-txaio-doc/html/_static/jquery.js /usr/share/javascript/jquery/latest/jquery.min.js
python-txaio-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-txaio-doc/html/_sources/api.txt
python-txaio-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-txaio-doc/html/_sources/overview.txt
python-txaio-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-txaio-doc/html/_sources/index.txt
python-txaio.src: W: spelling-error Summary(en_US) asyncio -> Asuncion
python-txaio.src: W: spelling-error %description -l en_US asyncio -> Asuncion
4 packages and 0 specfiles checked; 0 errors, 12 warnings.

ISSUES:
Provides: python2-txaio is missing.
Requires: js-jquery is missing.

Please fix that. Package is APPROVED.


--
Note: python guidelines are being updated, but the changes were not announced yet.
In case of this package the changes will be fairly cosmetic, so they can
be left for later, after the guidelines changes have stabilized and have been
formally announced.

> You will need Requires: js-jquery in the -doc subpackage.

I thought I added it. Guess I just forgot. I will add it before importing.

> Provides: python2-txaio is missing.

Corrected. Updated both SPEC and SRPM on the net.

Thanks for the review.


New Package SCM Request
=======================
Package Name: python-txaio
Short Description: Compatibility API between asyncio/Twisted/Trollius
Upstream URL: https://pypi.python.org/pypi/txaio
Owners: jujens
Branches: f22 f23
InitialCC:

Git done (by process-git-requests).

Package is in rawhide: http://koji.fedoraproject.org/koji/buildinfo?buildID=675377

I will build and propose an update for f22 and f23 once python-sphinx-theme-alabaster is in stable for f22 and f23.