Bug 1244655

Summary:	Review Request: async - StumbleUpon's Async Library
Product:	[Fedora] Fedora	Reporter:	gil cattaneo <puntogil>
Component:	Package Review	Assignee:	Gwyn Ciesla <gwync>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	gwync, package-review
Target Milestone:	---	Flags:	gwync: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-04-04 21:30:50 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1244657

Description gil cattaneo 2015-07-20 08:32:46 UTC

Spec URL: https://gil.fedorapeople.org/async.spec
SRPM URL: https://gil.fedorapeople.org/async-1.4.1-1.fc22.src.rpm
Description:
This Java library provides some useful building blocks to build
high-performance multi-threaded asynchronous applications in Java.
Its implementation was inspired by Twisted's asynchronous library
(twisted.internet.defer).
Fedora Account System Username: gil

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=10408076

Comment 1 gil cattaneo 2015-11-08 11:55:55 UTC

Spec URL: https://gil.fedorapeople.org/async.spec
SRPM URL: https://gil.fedorapeople.org/async-1.4.1-1.fc23.src.rpm

Comment 2 Upstream Release Monitoring 2015-11-08 12:00:32 UTC

gil's scratch build of async-1.4.1-1.fc23.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11750811

Comment 3 Gwyn Ciesla 2016-04-04 18:43:54 UTC

Good:

- rpmlint checks return:

Checking: async-1.4.1-1.fc23.noarch.rpm
          async-javadoc-1.4.1-1.fc23.noarch.rpm
          async-1.4.1-1.fc23.src.rpm
async.noarch: W: spelling-error %description -l en_US multi -> mulch, mufti
async.src: W: spelling-error %description -l en_US multi -> mulch, mufti
3 packages and 0 specfiles checked; 0 errors, 2 warnings.


- package meets naming guidelines
- package meets packaging guidelines
- license (BSD) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 

Looks clean.

APPROVED.

Comment 4 gil cattaneo 2016-04-04 18:58:26 UTC

Thanks for the review!

Package SCM Request: https://admin.fedoraproject.org/pkgdb/package/requests/4741

Comment 5 Gwyn Ciesla 2016-04-04 19:09:34 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/async