Bug 1244657

Spec URL: https://gil.fedorapeople.org/asynchbase.spec
SRPM URL: https://gil.fedorapeople.org/asynchbase-1.7.0-1.fc23.src.rpm

- update to 1.7.0

Spec URL: https://gil.fedorapeople.org/asynchbase.spec
SRPM URL: https://gil.fedorapeople.org/asynchbase-1.7.2-1.fc24.src.rpm

- update to 1.7.2

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=15973942

NOT Ready

@Marcin the package do not build with protobuf 3.x, the
actual release in rawhide. Please, skip this review.
Thanks

Spec URL: https://gil.fedorapeople.org/asynchbase.spec
SRPM URL: https://gil.fedorapeople.org/asynchbase-1.7.2-1.fc24.src.rpm

- move to protobuf 3.1

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=16648849

This is a review *template*. Besides handling the [ ]-marked tests you are
also supposed to fix the template before pasting into bugzilla:
- Add issues you find to the list of issues on top. If there isn't such
  a list, create one.
- Add your own remarks to the template checks.
- Add new lines marked [!] or [?] when you discover new things not
  listed by fedora-review.
- Change or remove any text in the template which is plain wrong. In this
  case you could also file a bug against fedora-review
- Remove the "[ ] Manual check required", you will not have any such lines
  in what you paste.
- Remove attachments which you deem not really useful (the rpmlint
  ones are mandatory, though)
- Remove this text



Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "BSD (3 clause)", "Apache (v2.0)", "Unknown or generated", "*No
     copyright* Apache (v2.0)". 18 files have unknown license. Detailed
     output of licensecheck in
     /home/vagrant/1244657-asynchbase/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[?]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[-]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[?]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 30720 bytes in 6 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Java:
[x]: Bundled jar/class files should be removed before build
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
     Note: Maven packages do not need to (Build)Require jpackage-utils. It
     is pulled in by maven-local
[x]: Javadoc documentation files are generated and included in -javadoc
     subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)

Maven:
[x]: If package contains pom.xml files install it (including metadata) even
     when building with ant
[x]: POM files have correct Maven mapping
[x]: Maven packages should use new style packaging
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage-
     utils for %update_maven_depmap macro
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     asynchbase-javadoc
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[?]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

Java:
[x]: Package uses upstream build method (ant/maven/etc.)
[x]: Packages are noarch unless they use JNI

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: asynchbase-1.7.2-1.fc26.noarch.rpm
          asynchbase-javadoc-1.7.2-1.fc26.noarch.rpm
          asynchbase-1.7.2-1.fc26.src.rpm
3 packages and 0 specfiles checked; 0 errors, 0 warnings.




Rpmlint (installed packages)
----------------------------
sh: /usr/bin/python: No such file or directory
2 packages and 0 specfiles checked; 0 errors, 0 warnings.



Requires
--------
asynchbase (rpmlib, GLIBC filtered):
    java-headless
    javapackages-tools
    mvn(com.google.guava:guava)
    mvn(com.google.protobuf:protobuf-java)
    mvn(com.stumbleupon:async)
    mvn(io.netty:netty:3)
    mvn(org.apache.zookeeper:zookeeper)
    mvn(org.slf4j:log4j-over-slf4j)
    mvn(org.slf4j:slf4j-api)

asynchbase-javadoc (rpmlib, GLIBC filtered):
    javapackages-tools



Provides
--------
asynchbase:
    asynchbase
    bundled(hbase)
    mvn(org.hbase:asynchbase)
    mvn(org.hbase:asynchbase:pom:)

asynchbase-javadoc:
    asynchbase-javadoc



Source checksums
----------------
https://github.com/OpenTSDB/asynchbase/archive/v1.7.2/asynchbase-1.7.2.tar.gz :
  CHECKSUM(SHA256) this package     : 38caa2e1467d6d2c1723c5b016c66d946634537160bd110f72890237faba2441
  CHECKSUM(SHA256) upstream package : 38caa2e1467d6d2c1723c5b016c66d946634537160bd110f72890237faba2441


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1244657
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, Java
Disabled plugins: C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Please check these points:

[?]: Package contains no bundled libraries without FPC exception.

Do we need to apply for FPC for bundled(hbase)?

[?]: Package is not known to require an ExcludeArch tag.
[?]: Package should compile and build into binary rpms on all supported
     architectures.

(In reply to marcindulak from comment #7)
> Please check these points:
> 
> [?]: Package contains no bundled libraries without FPC exception.
> 
> Do we need to apply for FPC for bundled(hbase)?

No guideline is says only to add bundled(foo)
https://fedoraproject.org/wiki/Bundled_Libraries?rd=Packaging:Bundled_Libraries#Treatment_of_Bundled_Libraries

> [?]: Package is not known to require an ExcludeArch tag.
I don't understand, "BuildArch:     noarch" ...

> [?]: Package should compile and build into binary rpms on all supported
>      architectures.
... as above ... ?

(In reply to marcindulak from comment #7)
> [?]: Package is not known to require an ExcludeArch tag.
> [?]: Package should compile and build into binary rpms on all supported
>      architectures.

Maybe, you should read this point of the java guideline: "Java programs that wish to make calls into native libraries do so via the Java Native Interface (JNI). A Java package uses JNI if it contains a .so file. Note that this file can be embedded within JAR files themselves."
https://fedoraproject.org/wiki/Packaging:Java#Packaging_JAR_files_that_use_JNI
This library do not use JNI and so is a noarch package. The make generate only an XML file (pom.xml) and this one is noarch

Thanks for the review!

create new SCM requests:
https://admin.fedoraproject.org/pkgdb/package/requests/9374

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/asynchbase

Task info: https://koji.fedoraproject.org/koji/taskinfo?taskID=17950725