Bug 1244766
Summary: | Storage Manager vs Storage Pool Manager | ||
---|---|---|---|
Product: | [Retired] oVirt | Reporter: | Yuko Katabami <ykatabam> |
Component: | ovirt-engine-webadmin | Assignee: | Allon Mureinik <amureini> |
Status: | CLOSED UPSTREAM | QA Contact: | Aharon Canan <acanan> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | 3.6 | CC: | acanan, amureini, bugs, ecohen, gklein, lsurette, mgoldboi, rbalakri, yeylon, ykatabam |
Target Milestone: | m1 | Keywords: | CodeChange |
Target Release: | 3.6.0 | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | storage | ||
Fixed In Version: | ovirt-engine-3.6.0_beta1.1 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2015-08-05 13:17:52 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | Storage | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Yuko Katabami
2015-07-20 12:56:14 UTC
The correct term is Storage Pool Manager (or SPM for short), you suggested. This keys, however, belong to messages that are no longer in use, and should simply be removed. The referenced patch removes all the unused keys (~130), including these three, and adds test cases to assure that having such leftovers won't happen again. Yuko/Einav - given the number of removed keys it may be a good idea to put off the translation efforts until this patch is merged in order to save redundant work translating messages that are never used in the application. The patch referenced in the external tracker does a couple of things relevant to current and future translations: 1. Removes a bunch of unused keys from AppErros.properties (including the three keys mentioned in the original report) 2. Renames keys that aren't legal java identifiers to legal identifiers by replacing "." with "_" (e.g., VALIDATION.TAGS.INVALID_TAG_NAME was renamed to -VALIDATION_TAGS_INVALID_TAG_NAME). 3. Adds unit tests to ensure that no further messages that aren't referenced by AppErrors.java could be added. Einav/Yuko - as far as I recall the guidance was that developers should only touch the English AppErrors files, so all the aforementioned changes were only performed there. If making the same changes on the translated files will help you, just let me know. (In reply to Allon Mureinik from comment #2) > The patch referenced in the external tracker does a couple of things > relevant to current and future translations: > > 1. Removes a bunch of unused keys from AppErros.properties (including the > three keys mentioned in the original report) > 2. Renames keys that aren't legal java identifiers to legal identifiers by > replacing "." with "_" (e.g., VALIDATION.TAGS.INVALID_TAG_NAME was renamed > to -VALIDATION_TAGS_INVALID_TAG_NAME). > 3. Adds unit tests to ensure that no further messages that aren't referenced > by AppErrors.java could be added. > > Einav/Yuko - as far as I recall the guidance was that developers should only > touch the English AppErrors files, so all the aforementioned changes were > only performed there. If making the same changes on the translated files > will help you, just let me know. Many thanks, Allon, no need to change any of the non-English files. The relevant keys will be removed from them automatically in my next pull from the translation system. Thank you Allon and Einav This is a code change - these messages aren't exposed to the user in any way, and are removed from the master and 3.6 branches. QA have no action item here, closing as UPSTREAM. |