Bug 1245110

Summary: traceback when stopping shinken daemon with module with default KillMode control-group
Product: [Fedora] Fedora EPEL Reporter: rasoso
Component: shinkenAssignee: David Hannequin <david.hannequin>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: epel7CC: david.hannequin, rasoso
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: shinken-2.4.1-1.fc21 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-08-13 20:19:17 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
start stop of poller daemon with named-pipe module none

Description rasoso 2015-07-21 08:52:02 UTC
Created attachment 1054230 [details]
start stop of poller daemon with named-pipe module

Description of problem:

The following traceback is observed when stopping the poller daemon:
[1437467506] ERROR: [Shinken] Worker '1' exit with an unmanaged exception : Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/shinken/worker.py", line 226, in work
    self.do_work(s, returns_queue, c)
  File "/usr/lib/python2.7/site-packages/shinken/worker.py", line 268, in do_work
    self.get_new_checks()
  File "/usr/lib/python2.7/site-packages/shinken/worker.py", line 146, in get_new_checks
    msg = self.s.get(block=False)
  File "<string>", line 2, in get
  File "/usr/lib64/python2.7/multiprocessing/managers.py", line 759, in _callmethod
    kind, result = conn.recv()
EOFError

This issue does not appear when using KillMode "process", instead of the default "control-group",
to be closer to the behavior of the SysV init script.


Version-Release number of selected component (if applicable):

shinken-arbiter-2.2-6.el7.noarch
shinken-scheduler-2.2-6.el7.noarch
shinken-reactionner-2.2-6.el7.noarch
shinken-broker-2.2-6.el7.noarch
shinken-poller-2.2-6.el7.noarch
shinken-receiver-2.2-6.el7.noarch
shinken-2.2-6.el7.noarch


How reproducible:

Always

Steps to Reproduce:
1. add a module (e.g. named-pipe) to a daemon (e.g. poller)
2. start it (wait for the configuration to be received) and stop it

Actual results:

Traceback and slow stop.

Expected results:

No traceback and fast stop.

Additional info:

pollerd log attached with start stop sequence and traceback issue.

systemd unit modification:
[root@centos7 shinken]# diff -up /usr/lib/systemd/system/shinken-poller.service.ORIG  /usr/lib/systemd/system/shinken-poller.service
--- /usr/lib/systemd/system/shinken-poller.service.ORIG 2015-07-21 04:34:00.712000000 -0400
+++ /usr/lib/systemd/system/shinken-poller.service      2015-07-21 04:48:13.018000000 -0400
@@ -5,6 +5,7 @@ After=syslog.target
 [Service]
 Type=forking
 ExecStart=/usr/sbin/shinken-poller -d -c /etc/shinken/daemons/pollerd.ini
+KillMode=process

 [Install]
 WantedBy=multi-user.target

Comment 1 David Hannequin 2015-07-21 21:56:09 UTC
Hi,

Thanks for your issue, i fix soon. 

Best regard

Comment 2 Fedora Update System 2015-07-24 14:17:02 UTC
shinken-2.2-9.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/shinken-2.2-9.fc22

Comment 3 Fedora Update System 2015-07-24 14:20:54 UTC
shinken-2.2-9.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/shinken-2.2-9.fc21

Comment 4 Fedora Update System 2015-07-24 14:22:33 UTC
shinken-2.2-9.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/shinken-2.2-9.el6

Comment 5 Fedora Update System 2015-07-24 14:26:59 UTC
shinken-2.2-9.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/shinken-2.2-9.el7

Comment 6 Fedora Update System 2015-07-24 16:20:32 UTC
shinken-2.4.1-1.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/shinken-2.4.1-1.fc22

Comment 7 Fedora Update System 2015-07-24 16:21:07 UTC
shinken-2.4.1-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/shinken-2.4.1-1.fc21

Comment 8 Fedora Update System 2015-07-24 16:24:38 UTC
shinken-2.4.1-1.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/shinken-2.4.1-1.el6

Comment 9 Fedora Update System 2015-07-24 16:31:34 UTC
shinken-2.4.1-1.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/shinken-2.4.1-1.el7

Comment 10 Fedora Update System 2015-07-27 23:09:51 UTC
Package shinken-2.4.1-1.el6:
* should fix your issue,
* was pushed to the Fedora EPEL 6 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=epel-testing shinken-2.4.1-1.el6'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-EPEL-2015-7321/shinken-2.4.1-1.el6
then log in and leave karma (feedback).

Comment 11 Fedora Update System 2015-08-13 20:19:17 UTC
shinken-2.4.1-1.el6 has been pushed to the Fedora EPEL 6 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 12 Fedora Update System 2015-08-13 20:23:33 UTC
shinken-2.4.1-1.el7 has been pushed to the Fedora EPEL 7 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 13 Fedora Update System 2015-08-15 02:11:21 UTC
shinken-2.4.1-1.fc22 has been pushed to the Fedora 22 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 14 Fedora Update System 2015-08-15 02:20:17 UTC
shinken-2.4.1-1.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.