Bug 1245684 (CVE-2015-3256)

Summary: CVE-2015-3256 polkit: Memory corruption via javascript rule evaluation
Product: [Other] Security Response Reporter: Vasyl Kaigorodov <vkaigoro>
Component: vulnerabilityAssignee: Red Hat Product Security <security-response-team>
Status: CLOSED ERRATA QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: unspecifiedCC: carnil, mitr, security-response-team, sisharma, slawomir, slong
Target Milestone: ---Keywords: Security
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
A denial of service flaw was found in how polkit handled authorization requests. A local, unprivileged user could send malicious requests to polkit, which could then cause the polkit daemon to corrupt its memory and crash.
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-02-16 13:40:11 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1271789, 1271790    
Bug Blocks: 1233809    
Attachments:
Description Flags
0001-Don-t-pass-an-uninitialized-JS-parameter.patch
none
0002-Don-t-add-extra-NULL-group-to-subject.groups.patch
none
0003-Don-t-store-unrooted-jsvals-on-heap.patch
none
0004-Fix-a-per-authorization-memory-leak.patch
none
0005-Fix-a-memory-leak-when-registering-an-authentication.patch
none
0006-Wrap-all-JS-usage-within-requests.patch
none
0007-Register-heap-based-JSObject-pointers-to-GC.patch
none
0008-Prevent-builds-against-SpiderMonkey-with-exact-stack.patch
none
0009-Clear-the-JS-operation-callback-before-invoking-JS-i.patch
none
0010-Fix-spurious-timeout-exceptions-on-GC.patch none

Description Vasyl Kaigorodov 2015-07-22 14:16:24 UTC
It was reported that polkit has a bug, that leads to a minor denial of service, or code execution/privilege escalation.
The only privilege necessary is ability to send D-Bus messages, not even necessarily directly to polkitd (usually privileged services ask polkitd for authorization based of a client request: client<->D-Bus<->service<->D-Bus<->polkitd); the attacker does not need special polkit status.
This bug allows a local user (a person on a multi-user system, or a daemon account after successfully attacking a daemon over the network) to corrupt memory of polkitd.
Corrupting polkitd memory can lead to a crash (known to happen), which is a minor DoS: a specific request being handled during the crash will not get a reply, but polkitd will then be automatically started when next polkit request arrives.
In general corrupting memory can lead to arbitrary code execution as polkitd (no proof of concept exists but I can see no reason for this to be impossible), controlling polkitd allows the attacker to grant to anyone access to any polkit-controlled service, including the ability to run any command as root via pkexec.

Initially reported in https://bugzilla.redhat.com/show_bug.cgi?id=910262
The patches are attached.

Comment 1 Vasyl Kaigorodov 2015-07-22 14:18:22 UTC
Created attachment 1054871 [details]
0001-Don-t-pass-an-uninitialized-JS-parameter.patch

Comment 2 Vasyl Kaigorodov 2015-07-22 14:18:25 UTC
Created attachment 1054872 [details]
0002-Don-t-add-extra-NULL-group-to-subject.groups.patch

Comment 3 Vasyl Kaigorodov 2015-07-22 14:18:27 UTC
Created attachment 1054873 [details]
0003-Don-t-store-unrooted-jsvals-on-heap.patch

Comment 4 Vasyl Kaigorodov 2015-07-22 14:18:29 UTC
Created attachment 1054874 [details]
0004-Fix-a-per-authorization-memory-leak.patch

Comment 5 Vasyl Kaigorodov 2015-07-22 14:18:32 UTC
Created attachment 1054875 [details]
0005-Fix-a-memory-leak-when-registering-an-authentication.patch

Comment 6 Vasyl Kaigorodov 2015-07-22 14:18:35 UTC
Created attachment 1054876 [details]
0006-Wrap-all-JS-usage-within-requests.patch

Comment 7 Vasyl Kaigorodov 2015-07-22 14:18:37 UTC
Created attachment 1054877 [details]
0007-Register-heap-based-JSObject-pointers-to-GC.patch

Comment 8 Vasyl Kaigorodov 2015-07-22 14:18:39 UTC
Created attachment 1054878 [details]
0008-Prevent-builds-against-SpiderMonkey-with-exact-stack.patch

Comment 9 Vasyl Kaigorodov 2015-07-22 14:18:42 UTC
Created attachment 1054879 [details]
0009-Clear-the-JS-operation-callback-before-invoking-JS-i.patch

Comment 10 Vasyl Kaigorodov 2015-07-22 14:18:44 UTC
Created attachment 1054880 [details]
0010-Fix-spurious-timeout-exceptions-on-GC.patch

Comment 13 errata-xmlrpc 2016-02-16 10:39:37 UTC
This issue has been addressed in the following products:

  Red Hat Enterprise Linux 7

Via RHSA-2016:0189 https://rhn.redhat.com/errata/RHSA-2016-0189.html