Bug 1246381

Summary: [abrt] torbrowser-launcher: client.py:1559:request:TypeError: _getEndpoint() takes exactly 4 arguments (2 given)
Product: [Fedora] Fedora Reporter: Martin Hvidberg <martin>
Component: torbrowser-launcherAssignee: Robert Mayr <robyduck>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 21CC: fedora, fuckel, oleg-sz, peter.meier, pj.pandit, rehol3, robyduck, r.v.f, stevenroose, subscribed-lists, wrcadk
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Unspecified   
URL: https://retrace.fedoraproject.org/faf/reports/bthash/1da52a3533e46f384af4648ecbec15a97bfe6635
Whiteboard: abrt_hash:3b4b50bb7ceef7a04de10b7c91f45e06961ab656
Fixed In Version: torbrowser-launcher-0.2.2-1.fc23 torbrowser-launcher-0.2.2-1.fc22 torbrowser-launcher-0.2.2-1.fc21 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-11-23 20:54:34 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
File: backtrace
none
File: environ none

Description Martin Hvidberg 2015-07-24 07:29:38 UTC
Description of problem:
trying to install and run tor

Version-Release number of selected component:
torbrowser-launcher-0.2.0-1.fc21

Additional info:
reporter:       libreport-2.3.0
cmdline:        /usr/bin/python2 /usr/bin/torbrowser-launcher
dso_list:       python-twisted-15.1.0-1.fc21.x86_64
executable:     /usr/bin/torbrowser-launcher
kernel:         4.0.8-200.fc21.x86_64
runlevel:       N 5
type:           Python
uid:            1013

Truncated backtrace:
client.py:1559:request:TypeError: _getEndpoint() takes exactly 4 arguments (2 given)

Traceback (most recent call last):
  File "/usr/bin/torbrowser-launcher", line 30, in <module>
    torbrowser_launcher.main()
  File "/usr/lib/python2.7/site-packages/torbrowser_launcher/__init__.py", line 69, in main
    app = Launcher(common, url_list)
  File "/usr/lib/python2.7/site-packages/torbrowser_launcher/launcher.py", line 130, in __init__
    self.build_ui()
  File "/usr/lib/python2.7/site-packages/torbrowser_launcher/launcher.py", line 284, in build_ui
    self.start(None)
  File "/usr/lib/python2.7/site-packages/torbrowser_launcher/launcher.py", line 293, in start
    self.run_task()
  File "/usr/lib/python2.7/site-packages/torbrowser_launcher/launcher.py", line 310, in run_task
    self.download('update check', self.common.paths['update_check_url'], self.common.paths['update_check_file'])
  File "/usr/lib/python2.7/site-packages/torbrowser_launcher/launcher.py", line 469, in download
    None)
  File "/usr/lib64/python2.7/site-packages/twisted/web/client.py", line 1926, in request
    deferred = self._agent.request(method, uri, headers, bodyProducer)
  File "/usr/lib64/python2.7/site-packages/twisted/web/client.py", line 1559, in request
    endpoint = self._getEndpoint(parsedURI)
TypeError: _getEndpoint() takes exactly 4 arguments (2 given)

Local variables in innermost frame:
self: <txsocksx.http.SOCKS5Agent object at 0x7f8e8453bf10>
uri: 'https://www.torproject.org/projects/torbrowser/RecommendedTBBVersions'
bodyProducer: None
headers: Headers({'user-agent': ['torbrowser-launcher']})
parsedURI: <twisted.web.client.URI object at 0x7f8e80efb650>
method: 'GET'

Potential duplicate: bug 1224571

Comment 1 Martin Hvidberg 2015-07-24 07:29:41 UTC
Created attachment 1055638 [details]
File: backtrace

Comment 2 Martin Hvidberg 2015-07-24 07:29:43 UTC
Created attachment 1055639 [details]
File: environ

Comment 3 Peter Meier 2015-08-01 23:35:24 UTC
I have the same problem on F22:

$ rpm -qi --scripts torbrowser-launcher
Name        : torbrowser-launcher
Version     : 0.2.0
Release     : 1.fc22
Architecture: noarch
Install Date: Sat 13 Jun 2015 11:46:44 AM CEST
Group       : Unspecified
Size        : 361791
License     : MIT
Signature   : RSA/SHA256, Sun 31 May 2015 10:53:56 PM CEST, Key ID 11adc0948e1431d5
Source RPM  : torbrowser-launcher-0.2.0-1.fc22.src.rpm
Build Date  : Sat 30 May 2015 05:19:27 PM CEST
Build Host  : arm04-builder05.arm.fedoraproject.org
Relocations : (not relocatable)
Packager    : Fedora Project
Vendor      : Fedora Project
URL         : https://github.com/micahflee/torbrowser-launcher
Summary     : Tor Browser Bundle managing tool
Description :
Tor Browser Launcher is intended to make the Tor Browser Bundle (TBB)
easier to maintain and use for GNU/Linux users. You install
torbrowser-launcher from your distribution's package manager
and it handles everything else, including:

* Downloading the most recent version of TBB for you,
  in your language and for your architecture
* Automatically updating
* Verifying the TBB's GnuPG signature
* Adding a "Tor Browser" application launcher to your desktop environment's menu


$ /usr/bin/torbrowser-launcher nic.ch
Tor Browser Launcher
By Micah Lee, licensed under MIT
version 0.2.0
https://github.com/micahflee/torbrowser-launcher
Updating over Tor
Checking for update
Downloading https://www.torproject.org/projects/torbrowser/RecommendedTBBVersions
Traceback (most recent call last):
  File "/usr/bin/torbrowser-launcher", line 30, in <module>
    torbrowser_launcher.main()
  File "/usr/lib/python2.7/site-packages/torbrowser_launcher/__init__.py", line 69, in main
    app = Launcher(common, url_list)
  File "/usr/lib/python2.7/site-packages/torbrowser_launcher/launcher.py", line 130, in __init__
    self.build_ui()
  File "/usr/lib/python2.7/site-packages/torbrowser_launcher/launcher.py", line 284, in build_ui
    self.start(None)
  File "/usr/lib/python2.7/site-packages/torbrowser_launcher/launcher.py", line 293, in start
    self.run_task()
  File "/usr/lib/python2.7/site-packages/torbrowser_launcher/launcher.py", line 310, in run_task
    self.download('update check', self.common.paths['update_check_url'], self.common.paths['update_check_file'])
  File "/usr/lib/python2.7/site-packages/torbrowser_launcher/launcher.py", line 469, in download
    None)
  File "/usr/lib64/python2.7/site-packages/twisted/web/client.py", line 1926, in request
    deferred = self._agent.request(method, uri, headers, bodyProducer)
  File "/usr/lib64/python2.7/site-packages/twisted/web/client.py", line 1559, in request
    endpoint = self._getEndpoint(parsedURI)
TypeError: _getEndpoint() takes exactly 4 arguments (2 given)
[mh@gasteiz ~]$ vi /usr/lib/python2.7/site-packages/torbrowser_launcher/launcher.py


$ cat /etc/system-release
Fedora release 22 (Twenty Two)

Comment 4 Christoph Erhardt 2015-08-26 15:36:57 UTC
Upstream bug report: https://github.com/micahflee/torbrowser-launcher/issues/192

Comment 5 Fedora End Of Life 2015-11-04 10:17:34 UTC
This message is a reminder that Fedora 21 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 21. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '21'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 21 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 6 Christoph Erhardt 2015-11-08 23:14:39 UTC
This bug is still present in Fedora 23.

Comment 8 Robert Mayr 2015-11-09 07:56:13 UTC
Yes this has been fixed but release 0.2.1 is still on its way (updates testing actually). 
I'll build 0.2.2 ASAP. Thank you.

Comment 9 Fedora Update System 2015-11-15 15:10:24 UTC
torbrowser-launcher-0.2.2-1.fc21 has been submitted as an update to Fedora 21. https://bodhi.fedoraproject.org/updates/FEDORA-2015-b1446d3a9f

Comment 10 Fedora Update System 2015-11-15 15:11:08 UTC
torbrowser-launcher-0.2.2-1.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-7fcae013d4

Comment 11 Fedora Update System 2015-11-15 15:11:49 UTC
torbrowser-launcher-0.2.2-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-d719cd6bfa

Comment 12 Fedora Update System 2015-11-16 04:50:53 UTC
torbrowser-launcher-0.2.2-1.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update torbrowser-launcher'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-7fcae013d4

Comment 13 Fedora Update System 2015-11-16 05:53:15 UTC
torbrowser-launcher-0.2.2-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update torbrowser-launcher'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-d719cd6bfa

Comment 14 Fedora Update System 2015-11-16 06:52:01 UTC
torbrowser-launcher-0.2.2-1.fc21 has been pushed to the Fedora 21 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update torbrowser-launcher'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-b1446d3a9f

Comment 15 Fedora Update System 2015-11-23 20:54:18 UTC
torbrowser-launcher-0.2.2-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Comment 16 Fedora Update System 2015-11-23 22:49:30 UTC
torbrowser-launcher-0.2.2-1.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.

Comment 17 Fedora Update System 2015-11-23 23:19:18 UTC
torbrowser-launcher-0.2.2-1.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report.