Bug 1246481

Summary:	rpc: fix binding brick issue while bind-insecure is enabled
Product:	[Community] GlusterFS	Reporter:	Prasanna Kumar Kalever <prasanna.kalever>
Component:	core	Assignee:	bugs <bugs>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.7.3	CC:	bugs, gluster-bugs, rgowdapp
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.7.3	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-07-30 09:51:23 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Prasanna Kumar Kalever 2015-07-24 12:24:24 UTC

Description of problem:

backporting http://review.gluster.org/#/c/11512/

problem:
    
    When bind-insecure is turned on (which is the default now), it may happen
    that brick is not able to bind to port assigned by Glusterd for example
    49192-49195...
    
    It seems to occur because the rpc_clnt connections are binding to ports in
    the same range. so brick fails to bind to a port which is already used by
    someone else
    
    solution:
    
    fix for now is to  make rpc_clnt to get port numbers from 65535 in a descending
    order, as a result port clash is minimized
    
    other fixes:
    
    previously rdma binds to port >= 1024 if it cannot find a free port < 1024,
    even when bind insecure was turned off(ref to commit '0e3fd04e'), this patch
    add's a check for bind-insecure in gf_rdma_client_bind function
    
    This patch also re-enable bind-insecure and allow insecure by default which was
    reverted (ref: commit cef1720) previously


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Anand Avati 2015-07-24 12:24:54 UTC

REVIEW: http://review.gluster.org/11758 (rpc: fix binding brick issue while bind-insecure is enabled) posted (#1) for review on release-3.7 by Prasanna Kumar Kalever

Comment 2 Anand Avati 2015-07-27 04:32:03 UTC

COMMIT: http://review.gluster.org/11758 committed in release-3.7 by Raghavendra G (rgowdapp) 
------
commit 5ebf298ec03bc929a4142e70ed105130cf9c58df
Author: Prasanna Kumar Kalever <prasanna.kalever>
Date:   Fri Jul 24 17:35:16 2015 +0530

    rpc: fix binding brick issue while bind-insecure is enabled
    
    This patch is backport of http://review.gluster.org/#/c/11512/
    
    > problem:
    
    > When bind-insecure is turned on (which is the default now), it may happen
    > that brick is not able to bind to port assigned by Glusterd for example
    > 49192-49195...
    >
    > It seems to occur because the rpc_clnt connections are binding to ports in
    > the same range. so brick fails to bind to a port which is already used by
    > someone else
    >
    > solution:
    >
    > fix for now is to  make rpc_clnt to get port numbers from 65535 in a
    > descending
    > order, as a result port clash is minimized
    >
    > other fixes:
    >
    > previously rdma binds to port >= 1024 if it cannot find a free port < 1024,
    > even when bind insecure was turned off(ref to commit '0e3fd04e'), this patch
    > add's a check for bind-insecure in gf_rdma_client_bind function
    >
    > This patch also re-enable bind-insecure and allow insecure by default
    > which was reverted (ref: commit cef1720) previously
    
    > Change-Id: Ia1cfa93c5454e2ae0ff57813689b75de282ebd07
    > BUG: 1238661
    > Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever>
    
    Change-Id: Iea55f9b2a57b5e24d3df2c5fafae12fe99e9dee0
    BUG: 1246481
    Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever>
    Reviewed-on: http://review.gluster.org/11758
    Tested-by: NetBSD Build System <jenkins.org>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Raghavendra G <rgowdapp>

Comment 3 Kaushal 2015-07-30 09:51:23 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.3, please open a new bug report.

glusterfs-3.7.3 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/12078
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user