Bug 1246546

Summary: "Host Name" should change to "Hostname" in Provider and Host editing forms
Product: Red Hat CloudForms Management Engine Reporter: Chris Shinn <cshinn>
Component: UI - OPSAssignee: Harpreet Kataria <hkataria>
Status: CLOSED ERRATA QA Contact: Jeff Teehan <jteehan>
Severity: low Docs Contact:
Priority: high    
Version: 5.5.0CC: hkataria, jhardy, mpovolny, obarenbo
Target Milestone: GA   
Target Release: 5.5.0   
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: 5.5.0.1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-12-08 13:23:46 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Chris Shinn 2015-07-24 14:34:00 UTC
Description of problem:
The term "Hostname" appears several times in the product. "Host Name" only seems to appear in the editing forms for providers and hosts. For consistency, these labels should be changed to Hostname

Version-Release number of selected component (if applicable):
ManageIQ botvinnik-1.20150721093844_eb92001

How reproducible:
100%

Steps to Reproduce:
1.
2.
3.

Actual results:
When editing a provider or host, the row header reads "Host Name (or IPv4 or IPv6 address)"

Expected results:
"Hostname (or IPv4 or IPv6 address)"

Additional info:

Comment 2 Chris Shinn 2015-07-24 17:47:15 UTC
I initially suggested "hostname" because it seemed more common within the application. 
However, upon checking with the corporate style guide https://mojo.redhat.com/docs/DOC-28115 , it appears that "host name" is the preferred term. I apologize for any inconvenience, an recommend that instances of "hostname" such as those that appear on the provider, host, vm, etc. summary pages be changed to "host name".

Comment 6 CFME Bot 2015-08-05 21:25:08 UTC
New commit detected on manageiq/master:
https://github.com/ManageIQ/manageiq/commit/ab5b12b351f0ce0af175a1a6a69d50c34b4f1dac

commit ab5b12b351f0ce0af175a1a6a69d50c34b4f1dac
Author:     Harpreet Kataria <hkataria>
AuthorDate: Wed Aug 5 13:19:58 2015 -0400
Commit:     Harpreet Kataria <hkataria>
CommitDate: Wed Aug 5 16:51:17 2015 -0400

    Changed label in UI from "Host Name" to "Hostname"
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1246546

 app/controllers/ops_controller/settings/ldap.rb                     | 2 +-
 app/helpers/provider_foreman_helper.rb                              | 2 +-
 app/views/ems_cloud/_form_fields.html.haml                          | 2 +-
 app/views/ems_container/_form_fields.html.haml                      | 2 +-
 app/views/ems_infra/_form_fields.html.haml                          | 2 +-
 app/views/host/_form.html.haml                                      | 2 +-
 app/views/layouts/quadicon/_ext_management_system.html.haml         | 2 +-
 app/views/layouts/quadicon/_host.html.haml                          | 6 +++---
 app/views/ops/_ldap_domain_show.html.haml                           | 2 +-
 app/views/ops/_ldap_forest_entries.html.haml                        | 2 +-
 app/views/ops/_ldap_server_entries.html.haml                        | 2 +-
 app/views/ops/_ldap_verify_button.html.haml                         | 2 +-
 app/views/ops/_settings_authentication_tab.html.haml                | 2 +-
 app/views/storage_manager/_form.html.haml                           | 2 +-
 product/views/ConfiguredSystem.yaml                                 | 2 +-
 product/views/EmsContainer.yaml                                     | 2 +-
 product/views/ManageIQ_Providers_InfraManager.yaml                  | 2 +-
 product/views/MiqServer.yaml                                        | 2 +-
 product/views/StorageManager.yaml                                   | 2 +-
 spec/views/ems_cloud/_form_fields.html.haml_spec.rb                 | 2 +-
 spec/views/ems_container/_form_fields.html.haml_spec.rb             | 2 +-
 spec/views/ems_infra/_form_fields.html.haml_spec.rb                 | 2 +-
 spec/views/host/_form.html.haml_spec.rb                             | 3 ++-
 .../views/layouts/quadicon/_ext_management_system.html.haml_spec.rb | 2 +-
 24 files changed, 27 insertions(+), 26 deletions(-)

Comment 7 CFME Bot 2015-08-05 21:31:24 UTC
New commit detected on manageiq/master:
https://github.com/ManageIQ/manageiq/commit/ab5b12b351f0ce0af175a1a6a69d50c34b4f1dac

commit ab5b12b351f0ce0af175a1a6a69d50c34b4f1dac
Author:     Harpreet Kataria <hkataria>
AuthorDate: Wed Aug 5 13:19:58 2015 -0400
Commit:     Harpreet Kataria <hkataria>
CommitDate: Wed Aug 5 16:51:17 2015 -0400

    Changed label in UI from "Host Name" to "Hostname"
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1246546

 app/controllers/ops_controller/settings/ldap.rb                     | 2 +-
 app/helpers/provider_foreman_helper.rb                              | 2 +-
 app/views/ems_cloud/_form_fields.html.haml                          | 2 +-
 app/views/ems_container/_form_fields.html.haml                      | 2 +-
 app/views/ems_infra/_form_fields.html.haml                          | 2 +-
 app/views/host/_form.html.haml                                      | 2 +-
 app/views/layouts/quadicon/_ext_management_system.html.haml         | 2 +-
 app/views/layouts/quadicon/_host.html.haml                          | 6 +++---
 app/views/ops/_ldap_domain_show.html.haml                           | 2 +-
 app/views/ops/_ldap_forest_entries.html.haml                        | 2 +-
 app/views/ops/_ldap_server_entries.html.haml                        | 2 +-
 app/views/ops/_ldap_verify_button.html.haml                         | 2 +-
 app/views/ops/_settings_authentication_tab.html.haml                | 2 +-
 app/views/storage_manager/_form.html.haml                           | 2 +-
 product/views/ConfiguredSystem.yaml                                 | 2 +-
 product/views/EmsContainer.yaml                                     | 2 +-
 product/views/ManageIQ_Providers_InfraManager.yaml                  | 2 +-
 product/views/MiqServer.yaml                                        | 2 +-
 product/views/StorageManager.yaml                                   | 2 +-
 spec/views/ems_cloud/_form_fields.html.haml_spec.rb                 | 2 +-
 spec/views/ems_container/_form_fields.html.haml_spec.rb             | 2 +-
 spec/views/ems_infra/_form_fields.html.haml_spec.rb                 | 2 +-
 spec/views/host/_form.html.haml_spec.rb                             | 3 ++-
 .../views/layouts/quadicon/_ext_management_system.html.haml_spec.rb | 2 +-
 24 files changed, 27 insertions(+), 26 deletions(-)

Comment 8 Jeff Teehan 2015-09-30 21:22:52 UTC
Used 5.5.0.3 and verified versus 5.4.2

I checked as many as I could find as compared to 5.4.2 and they had changed correctly.  The rest I just looked at the code check-in to see if a space was missing or if someone accidentally deleted one or more of the quotes.

Moving to Verified.

Comment 10 errata-xmlrpc 2015-12-08 13:23:46 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2015:2551