Bug 1246594

Summary:	git-annex addurl --file ignores https url proto, fallsback to http silently
Product:	[Fedora] Fedora EPEL	Reporter:	Justin Sherrill <jsherril>
Component:	git-annex	Assignee:	Ben Boeckel <fedora>
Status:	CLOSED EOL	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	el6	CC:	fedora, haskell-devel, petersen
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-11-30 15:00:13 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Justin Sherrill 2015-07-24 16:16:27 UTC

Description of problem:

when using:

git annex addurl --file somefile https://webserver.example.com/somefile

git annex does not use https, but fallsback to http without any sort of warning or error.  


Version-Release number of selected component (if applicable):
git-annex-3.20120522-2.1.el6.x86_64

How reproducible:
always


Steps to Reproduce:
1. in a git repo,  download a file 'foo', and run 'git annex add foo'
2. commit this annexed file, push it to a remote
3. in a separate directory checkout the git repo
4. run  git-annex addurl --file foo  https://server/path/to/foo

Actual results:

git-annex will attempt to download the file over http.  If port 80 is blocked, git annex will error with connection refused. An strace shows it clearly trying on port 80:

connect(3, {sa_family=AF_INET, sin_port=htons(80), sin_addr=inet_addr("192.168.0.127")}, 16) = -1 EINPROGRESS (Operation now in progress)

if you are monitoring your web server logs (when port 80 is allowed), you will see it attempt to connect over port 80 and never over port 443.

Expected results:

connects over port 443 via https

Additional info:

oddly enough if you leave out --file foo  it will attempt to use ssl.

Comment 1 Ben Cotton 2020-11-05 16:49:16 UTC

This message is a reminder that EPEL 6 is nearing its end of life. Fedora will stop maintaining and issuing updates for EPEL 6 on 2020-11-30. It is our policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a 'version' of 'el6'.

Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later EPEL version.

Thank you for reporting this issue and we are sorry that we were not able to fix it before EPEL 6 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged  change the 'version' to a later Fedora version prior this bug is closed as described in the policy above.

Comment 2 Ben Cotton 2020-11-30 15:00:13 UTC

EPEL el6 changed to end-of-life (EOL) status on 2020-11-30. EPEL el6 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
EPEL please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.