Bug 1247351

Summary:	[debuginfo package] libcdio ships executable source files
Product:	[Fedora] Fedora	Reporter:	Christian Stadelmann <fedora>
Component:	libcdio	Assignee:	Adrian Reber <adrian>
Status:	CLOSED UPSTREAM	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	22	CC:	adrian, fkluknav, hhorak
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-07-28 16:29:42 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Christian Stadelmann 2015-07-27 19:39:35 UTC

Description of problem:
These source files from libcdio-debuginfo are executable:
lib/driver/MSWindows/win32.c
lib/driver/image/bincue.c
lib/driver/image/cdrdao.c
lib/driver/sector.c
lib/driver/util.c

Version-Release number of selected component (if applicable):
0.93

How reproducible:
always (see rpm package)

Comment 1 Adrian Reber 2015-07-27 20:30:40 UTC

Thanks for the bug report, but are you sure that really is a problem. This is how we get the source code from upstream. This sounds like something which should be discussed with upstream.

I can change the files in the build process to be not executable but I do not really see the benefit. I would recommend contacting the upstream authors of libcdio so that they can fix it in git.

Comment 2 Christian Stadelmann 2015-07-27 22:20:34 UTC

In theory, yes (if the file started with something like a crunchbang, e.g. !#/bin/sh). But yes, I think upstream git fixes would be the best.

Comment 3 Adrian Reber 2015-07-28 16:29:42 UTC

Resolved in the upstream repository:

http://git.savannah.gnu.org/gitweb/?p=libcdio.git;a=commit;h=8a8bca964108b7a8c70fa503932160e98eb5af1e