Bug 1247627
| Summary: | [RFE] pod list in "browse" tab shows spinning icon which is confusing | ||
|---|---|---|---|
| Product: | OpenShift Container Platform | Reporter: | Erik M Jacobs <ejacobs> |
| Component: | Management Console | Assignee: | Robb Hamilton <rhamilto> |
| Status: | CLOSED ERRATA | QA Contact: | Yanping Zhang <yanpzhan> |
| Severity: | low | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 3.0.0 | CC: | dmcphers, jforrest, jokerman, libra-bugs, libra-onpremise-devel, mmccomas |
| Target Milestone: | --- | ||
| Target Release: | 3.7.0 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-12-18 13:22:48 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Attachments: | |||
|
Description
Erik M Jacobs
2015-07-28 13:17:31 UTC
@rhamilto one you can ponder, the answer may be we don't change anything but we should consider it Created attachment 1231209 [details]
Replacing fa-refresh with pficon-running
Created attachment 1231211 [details]
Replacing fa-refresh with pficon-running with motion
The sole use of color is problematic for colorblind users (estimates are as high as 10% of the male population), so I think we'll also need to consider shape and/or motion as well. Brainstorming: PatternFly includes a "running" icon (see pficon-running at https://www.patternfly.org/styles/icons), which we could use in place of the existing fa-refresh. Coupled with the addition of color and retaining the current rules regarding motion (spin) [1], this could be a step towards improvement. See attachments. [1] if there are more than one status icons on the page, the motion is disabled (e.g., browse/pods) Agreed that color only is not an option. I'm curious if the patternfly folks intended that icon to be used without motion? I'm not sure I would see that in its static state and get 'running' from it. Whereas refresh is able to indicate motion even when it's static. Given that we also use fa-refresh to indicate active deployments, what if we switch builds to pficon-running instead of pods? That way, we retain the meaning for both deployments and pods, but create a unique instance for builds (since it seems to be the outlier)? It seems we could always spin pficon-running for builds (thus alleviating the concern about the icon not indicating 'running') since a build has a finite time span and won't typically have multiples running concurrently? Created attachment 1231882 [details]
Travis build in progress indicator
Food for thought: Travis uses this animated "icon" to indicate a build is running.
Created attachment 1231883 [details]
Jenkins build in progress indicator
Food for thought: Jenkins uses this animated "icon" to indicate a build is running.
I'm not sure we should have different icons for the same status labels like "Running." They also show together on the monitoring page, which might look odd. (In reply to Erik M Jacobs from comment #0) > I think it would be better to adopt a color scheme dot for the pod status > that also should match whatever colors we use on the overview tab to > indicate pod health / pod status. > > green = healthy > yellow = unhealthy (perhaps not yet ready, etc) > red = failed / warning (perhaps couldn't schedule, failed health check, etc) > > and so on and so forth. > > This would be a much more "expected" user experience. For what it's worth, we've done something like this already. Pods with crashing containers now have a red `X` and status displayed even though the pod is "Running." So you can see when a pod is unhealthy directly from this list. We also show the number of containers ready in the table. Created attachment 1232278 [details]
Newer Jenkins build in progress indicator
Created attachment 1292950 [details]
Jenkins Blue Ocean build in progress indicator (animated gif)
Created attachment 1292954 [details]
Jenkins Blue Ocean build progress indicator 2 (animated gif)
Created attachment 1343295 [details]
Pods list in v3.7
With the upcoming 3.7 release, the browse pods table has been revised since this bug was originally filed.
* the running icons no longer spin
* unhealthy pods get a red x icon instead of the refresh icon
Erik, are these changes sufficient to address your concerns?
At this point our users are going to expect the refresh icon to indicate a running pod on this page. I don't anticipate changing this significantly. As already mentioned we've addressed the "running but crashing" scenario, so marking MODIFIED for that reason. PR to resolve: https://github.com/openshift/origin/pull/6083 Checked on 3.7 env with version v3.7.13. Now on pods page, the status icon for running pods is a refresh icon and doesn't spin. The status icon for failed pod is a red x. According to comment 14, these are all the fixes for the bug, so I'd like to move the bug to Verified. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2017:3464 |