Bug 1247781
| Summary: | hammer queries defaults to 1000 items per page | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Satellite | Reporter: | sthirugn <sthirugn> | ||||
| Component: | Hammer | Assignee: | Martin Bacovsky <mbacovsk> | ||||
| Status: | CLOSED ERRATA | QA Contact: | sthirugn <sthirugn> | ||||
| Severity: | high | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 6.1.0 | CC: | adprice, bbuckingham, bkearney, ehelms, mhulan, mmccune, ohadlevy, oprazak, sshtein, sthirugn, tstrachota | ||||
| Target Milestone: | Unspecified | Keywords: | Regression, Triaged | ||||
| Target Release: | Unused | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| URL: | http://projects.theforeman.org/issues/14530 | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | rubygem-hammer_cli-0.5.1.6-1,rubygem-hammer_cli_foreman-0.5.1.8-1 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2016-07-27 11:37:02 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
sthirugn@redhat.com
2015-07-28 20:54:05 UTC
Just to clarify, the command '# time hammer -u admin -p changeme erratum list' listed 1000 items but I was expecting to see first 20 items with options to search next. this still respects the page and per_page options if passed in at the command line via --page and --per_page or when included in api requests. We actually changed this on purpose for 6.1 to turn of pagination by default: https://bugzilla.redhat.com/show_bug.cgi?id=1190857 the side effect is that some API calls can return a *lot* of data. For 6.2 we can investigate a few options: * Timing functions where hammer will indicate the call is taking a while and possibly returning lots of data. give the user a suggestion to CTRL+C and use the --per-page option * Have APIs offer a default pagination with the requirement to use a param to indicate you want *all* results After https://github.com/theforeman/hammer-cli/pull/174 you can add a default option for pagination. You can even scope it to a specific resourse. I think it will cover both cases - if a user wants, he can add a pagination option, and the global default is full results. Is it a valid workaround? Adding needinfo for Suresh based on comment #9 ACK for Comment 9 behavior. It should be. The related BZ is https://bugzilla.redhat.com/show_bug.cgi?id=1154383 which is in ON_QA state and included in SNAP1. Shimon, I chatted with Suresh in irc. Since the behavior is addressed in the other BZ, we are going to move this one to ON_QA and he can run through verification. This bug failed in Satellite 6.2.0-beta-snap4 due to the same reason mentioned in https://bugzilla.redhat.com/show_bug.cgi?id=1154383#c10 Created an upstream PR to fix the issue, temporary workaround in https://bugzilla.redhat.com/show_bug.cgi?id=1154383 this is solved via 1154383 and associated bugs, moving ON_QA Failed in Satellite 6.2-beta-snap-6. I don't see any per-page options supported. Only organization_id, location_id are shown. [root@sat6host ~] # hammer -u admin -p changeme defaults providers ---------|------------------------------|------------------------------------------------------------- PROVIDER | SUPPORTED DEFAULTS | DESCRIPTION ---------|------------------------------|------------------------------------------------------------- foreman | organization_id, location_id | Use the default organization and/or location from the server ---------|------------------------------|------------------------------------------------------------- More test steps are also documented in https://bugzilla.redhat.com/show_bug.cgi?id=1154383#c19 Let sum up the status: - there is a bug in hammer causing per_page from the config file is being ignored. That is IMO the primary reason for this BZ. PR is almost ready - I can confirm the workaround Shimon suggested works: $ hanner defaults add --param-name per_page --param-value 3 $ hammer template list ---|----------------------------|---------- ID | NAME | TYPE ---|----------------------------|---------- 7 | Alterator default | provision 8 | Alterator default finish | finish 9 | Alterator default PXELinux | PXELinux ---|----------------------------|---------- To improve UX I'm adding message with page/total to the incomplete listings Created redmine issue http://projects.theforeman.org/issues/14530 from this bug Moving to POST since upstream bug http://projects.theforeman.org/issues/14530 has been closed Created attachment 1159824 [details] hammer pagination I do not think this got cherrypicked right since the relevant code is missing (RHEL6, snap 12). Line 331 in hammer_cli_foreman/commands.rb should be: https://github.com/theforeman/hammer-cli-foreman/blob/master/lib/hammer_cli_foreman/commands.rb#L331 but is: pagination_supported? && option_per_page.nil? && option_page.nil? the screenshot provides more detailed info Verified with: tfm-rubygem-hammer_cli-0.5.1.7-1.el7sat.noarch tfm-rubygem-hammer_cli_foreman-0.5.1.8-1.el7sat.noarch Hammer reflected on the per-page setting from config files. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2016:1501 |