Bug 124857
Summary: | Official Broadcom BCM5700 driver doesn't build on fc2 (missing "genapic" symbol) | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Richard Lloyd <rkl> |
Component: | kernel | Assignee: | Arjan van de Ven <arjanv> |
Status: | CLOSED WONTFIX | QA Contact: | Brian Brock <bbrock> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | 2 | ||
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | i686 | ||
OS: | Linux | ||
URL: | http://www.broadcom.com/drivers/downloaddrivers.php | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2004-05-31 12:51:06 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Richard Lloyd
2004-05-31 12:40:15 UTC
why on earth would a network driver need generic apic stuff... nic drivers shouldn't touch core irq routing infrastructure from the driver: printk(KERN_ERR "%s: Duplicate entry of the interrupt handler by " "processor %d.\n", dev->name, hard_smp_processor_id()); that hard_smp_processor_id() is actually a bug; they use the wrong function to get the current cpu number, they should have used smp_processor_id() instead....... Thanks for pointing that out - at least we have the fix in Bugzilla for anyone else who might try and report this issue. I have sent an e-mail to the BCM5700 driver author to request that he uses smp_processor_id() instead of hard_smp_processor_id() in the next release. If I put that change in the driver source, it builds and runs happily with the shipped FC2 kernel. I suspect SuSE put the genapic export "fix" in because it would keep bug reports down (maybe they reckoned that the next BCM5700 driver release might be not be for months and enough people had complained to them about the issue for them to kludge their source), but it's not really the right solution, as you correctly explained. |