Bug 1249287
Summary: | Uneeded dependency of tcsh | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Sitsofe Wheeler <sitsofe> |
Component: | dt | Assignee: | Ondrej Kozina <okozina> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | low | Docs Contact: | |
Priority: | low | ||
Version: | 22 | CC: | agk, gmazyland, okozina |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | x86_64 | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | dt-18.32-3.fc22 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2016-02-29 22:22:05 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Sitsofe Wheeler
2015-08-01 09:59:03 UTC
Let's see if I can find a way how to bend the .spec file to not to add such dependency. I been thinking about this too. I'm taking a look at https://fedoraproject.org/wiki/PackagingDrafts/FilteringAutomaticDependencies and will post somehting if you don't get there first :-) How about this: --- SPECS/dt.spec.old 2014-09-24 16:21:31.000000000 +0000 +++ SPECS/dt.spec 2015-08-03 18:08:44.150253653 +0000 @@ -34,6 +34,7 @@ Available documentation is located in %{_defaultdocdir}/%{name}. Sample scripts and config data are installed in %{_datadir}/%{name}. +%global __requires_exclude_from ^%{_datadir}/%{name}/.*$ %prep %setup -q -n dt.v%{version} %patch0 -p1 (From http://www.rpm.org/wiki/PackagerDocs/DependencyGenerator ) dt-18.32-3.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/dt-18.32-3.fc22 Hi Sitsofe, I applied your patch. Thanks! Hi Ondrej! After you applied this patch I started revisiting this issue. First up I got the recommended location of __requires_exclude_from wrong. Apparently it should go "before %description, but after any other definitions" (https://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering#Location_of_macro_invocation ). Next I took a look at how git coped with this. Over in Bug #492490#c2 they talk about how they ship a lot of contributor scripts but strip off their execute permission so RPM doesn't search those files for dependencies. If only someone had mentioned that this might be another plan on the packaging wiki pages... Finally I've now come to realise there's a lot more in the Scripts directory than the dt? scripts shipped (butterfly.ksh and DiskTests.ksh look useful) - does it make sense to ship more? If so should they be moved to /usr/share/doc/dt ? Doing a quick locate /usr/share/\*.*sh | sort shows some packages (git, socat, bash) shove example scripts in /usr/share/doc whereas other (git-core, vlc) put them in /usr/share/<package>/ . dt-18.32-3.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update dt'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/dt-18.32-3.fc22 Could this be pushed to the main repository - I posted anonymous on bodhi... Hi Sitsofe, so I somehow messed with my notifications setting and didn't receive the message about it being eligible for stable. I'll look into it:( Also I'll revisit the patch for other Fedoras 23+ but will push it in f22 in current version. dt-18.32-3.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. Thanks Ondrej! |