Bug 1249743

Test builds:
https://copr.fedoraproject.org/coprs/williamjmorenor/fedora-review-test/monitor/

Spec URL: https://williamjmorenor.fedorapeople.org/rpmdev/kaadbg.spec
SRPM URL: https://williamjmorenor.fedorapeople.org/rpmdev/kaadbg-0.3.0-1.fc22.src.rpm

Hello William,

I think you updated the spec but you didn't rebuild the srpms.
So LICENSE file from the patch is missing.

[root@d7c7b3161665 noarch]# rpm -qpl kaadbg-0.3.0-0.fc24.noarch.rpm 
/usr/lib/python3.4/site-packages/kaadbg
/usr/lib/python3.4/site-packages/kaadbg-0.3.0-py3.4.egg-info
/usr/lib/python3.4/site-packages/kaadbg-0.3.0-py3.4.egg-info/PKG-INFO
/usr/lib/python3.4/site-packages/kaadbg-0.3.0-py3.4.egg-info/SOURCES.txt
/usr/lib/python3.4/site-packages/kaadbg-0.3.0-py3.4.egg-info/dependency_links.txt
/usr/lib/python3.4/site-packages/kaadbg-0.3.0-py3.4.egg-info/top_level.txt
/usr/lib/python3.4/site-packages/kaadbg/__init__.py
/usr/lib/python3.4/site-packages/kaadbg/__pycache__
/usr/lib/python3.4/site-packages/kaadbg/__pycache__/__init__.cpython-34.pyc
/usr/lib/python3.4/site-packages/kaadbg/__pycache__/__init__.cpython-34.pyo
/usr/lib/python3.4/site-packages/kaadbg/__pycache__/debug.cpython-34.pyc
/usr/lib/python3.4/site-packages/kaadbg/__pycache__/debug.cpython-34.pyo
/usr/lib/python3.4/site-packages/kaadbg/__pycache__/run.cpython-34.pyc
/usr/lib/python3.4/site-packages/kaadbg/__pycache__/run.cpython-34.pyo
/usr/lib/python3.4/site-packages/kaadbg/debug.py
/usr/lib/python3.4/site-packages/kaadbg/run.py
/usr/share/doc/kaadbg
/usr/share/doc/kaadbg/README.rst


Otherwise that looks ok.

Spec URL: https://williamjmorenor.fedorapeople.org/rpmdev/kaadbg.spec
SRPM URL: https://williamjmorenor.fedorapeople.org/rpmdev/kaadbg-0.3.0-1.fc22.src.rpm

Here is the updated links to the last release.

Hello William,

Everything is ok from my point of view.
Just inform upstream to create a license file to be able to remove the License patch for the next release.


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated". 3 files have unknown license. Detailed
     output of licensecheck in
     /home/uggla/rpmbuild/SPECS/1249743-kaadbg/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[-]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[?]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: kaadbg-0.3.0-1.fc24.noarch.rpm
          kaadbg-0.3.0-1.fc24.src.rpm
kaadbg.noarch: W: spelling-error Summary(en_US) kaa -> aka, baa
kaadbg.noarch: W: spelling-error %description -l en_US kaa -> aka, baa
kaadbg.src: W: spelling-error Summary(en_US) kaa -> aka, baa
kaadbg.src: W: spelling-error %description -l en_US kaa -> aka, baa
2 packages and 0 specfiles checked; 0 errors, 4 warnings.




Rpmlint (installed packages)
----------------------------
sh: /usr/bin/python: No such file or directory
1 packages and 0 specfiles checked; 0 errors, 0 warnings.



Requires
--------
kaadbg (rpmlib, GLIBC filtered):
    python(abi)



Provides
--------
kaadbg:
    kaadbg



Source checksums
----------------
https://pypi.python.org/packages/source/k/kaadbg/kaadbg-0.3.0.tar.gz :
  CHECKSUM(SHA256) this package     : c1d310f0981143bad3458e544302a7883c2a4579c91bdc81d49e7eba51b00a84
  CHECKSUM(SHA256) upstream package : c1d310f0981143bad3458e544302a7883c2a4579c91bdc81d49e7eba51b00a84

William, I think you shoulb push this one to rawhide.

There is a rawhide build, but I forget to set the but numbre in the F23 update.

http://koji.fedoraproject.org/koji/packageinfo?packageID=21138