Bug 1249969

Summary:	binutils patches don't apply on aarch64
Product:	[Fedora] Fedora	Reporter:	Peter Robinson <pbrobinson>
Component:	binutils	Assignee:	Nick Clifton <nickc>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	urgent	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	jakub, nickc
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-08-04 16:38:54 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	922257

Description Peter Robinson 2015-08-04 09:16:51 UTC

It's generally considered bad form to apply patches on arch specific basis, if you must please test they still apply on a rebase!

binutils-2.25.1-1.fc24

http://arm.koji.fedoraproject.org/koji/taskinfo?taskID=3113321

Mock Version: 1.2.10
Mock Version: 1.2.10
ENTER do(['bash', '--login', '-c', '/usr/bin/rpmbuild -bs --target aarch64 --nodeps /builddir/build/SPECS/binutils.spec'], chrootPath='/var/lib/mock/SHADOWBUILD-f24-build-663854-587208/root'shell=FalseprintOutput=Falseenv={'LANG': 'en_US.UTF-8', 'TERM': 'vt100', 'SHELL': '/bin/bash', 'PROMPT_COMMAND': 'printf "\x1b]0;<mock-chroot>\x07<mock-chroot>"', 'PATH': '/usr/bin:/bin:/usr/sbin:/sbin', 'HOME': '/builddir', 'HOSTNAME': 'mock'}gid=425user='mockbuild'timeout=86400logger=<mockbuild.trace_decorator.getLog object at 0x3ff91989890>uid=1000)
Executing command: ['bash', '--login', '-c', '/usr/bin/rpmbuild -bs --target aarch64 --nodeps /builddir/build/SPECS/binutils.spec'] with env {'LANG': 'en_US.UTF-8', 'TERM': 'vt100', 'SHELL': '/bin/bash', 'PROMPT_COMMAND': 'printf "\x1b]0;<mock-chroot>\x07<mock-chroot>"', 'PATH': '/usr/bin:/bin:/usr/sbin:/sbin', 'HOME': '/builddir', 'HOSTNAME': 'mock'} and shell False
warning: Could not canonicalize hostname: aarch64-05a.arm.fedoraproject.org
Building target platforms: aarch64
Building for target aarch64
Wrote: /builddir/build/SRPMS/binutils-2.25.1-1.fc24.src.rpm
Child return code was: 0
LEAVE do --> 

ENTER do(['bash', '--login', '-c', '/usr/bin/rpmbuild -bb --target aarch64 --nodeps  /builddir/build/SPECS/binutils.spec '], chrootPath='/var/lib/mock/SHADOWBUILD-f24-build-663854-587208/root'shell=FalseprintOutput=Falseenv={'LANG': 'en_US.UTF-8', 'TERM': 'vt100', 'SHELL': '/bin/bash', 'PROMPT_COMMAND': 'printf "\x1b]0;<mock-chroot>\x07<mock-chroot>"', 'PATH': '/usr/bin:/bin:/usr/sbin:/sbin', 'HOME': '/builddir', 'HOSTNAME': 'mock'}gid=425user='mockbuild'timeout=86400logger=<mockbuild.trace_decorator.getLog object at 0x3ff91989890>uid=1000)
Executing command: ['bash', '--login', '-c', '/usr/bin/rpmbuild -bb --target aarch64 --nodeps  /builddir/build/SPECS/binutils.spec '] with env {'LANG': 'en_US.UTF-8', 'TERM': 'vt100', 'SHELL': '/bin/bash', 'PROMPT_COMMAND': 'printf "\x1b]0;<mock-chroot>\x07<mock-chroot>"', 'PATH': '/usr/bin:/bin:/usr/sbin:/sbin', 'HOME': '/builddir', 'HOSTNAME': 'mock'} and shell False
Building target platforms: aarch64
Building for target aarch64
Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.volrqp
+ umask 022
+ cd /builddir/build/BUILD
+ cd /builddir/build/BUILD
+ rm -rf binutils-2.25.1
+ /usr/bin/bzip2 -dc /builddir/build/SOURCES/binutils-2.25.1.tar.bz2
+ /usr/bin/tar -xf -
+ STATUS=0
+ '[' 0 -ne 0 ']'
+ cd binutils-2.25.1
+ /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w .
+ echo 'Patch #1 (binutils-2.20.51.0.2-libtool-lib64.patch):'
Patch #1 (binutils-2.20.51.0.2-libtool-lib64.patch):
+ /usr/bin/cat /builddir/build/SOURCES/binutils-2.20.51.0.2-libtool-lib64.patch
+ /usr/bin/patch -p1 -b --suffix .libtool-lib64~ --fuzz=0
patching file bfd/configure
Hunk #1 succeeded at 10781 (offset 19 lines).
patching file binutils/configure
Hunk #1 succeeded at 10579 (offset 19 lines).
patching file gas/configure
Hunk #1 succeeded at 10327 (offset -220 lines).
patching file gprof/configure
Hunk #1 succeeded at 10257 (offset -228 lines).
patching file ld/configure
Hunk #1 succeeded at 11072 (offset 106 lines).
patching file opcodes/configure
Hunk #1 succeeded at 10506 (offset 10 lines).
+ echo 'Patch #2 (binutils-2.20.51.0.10-ppc64-pie.patch):'
Patch #2 (binutils-2.20.51.0.10-ppc64-pie.patch):
+ /usr/bin/cat /builddir/build/SOURCES/binutils-2.20.51.0.10-ppc64-pie.patch
+ /usr/bin/patch -p1 -b --suffix .ppc64-pie~ --fuzz=0
patching file bfd/elf64-ppc.c
Hunk #1 succeeded at 14447 (offset 924 lines).
+ echo 'Patch #4 (binutils-2.25-version.patch):'
Patch #4 (binutils-2.25-version.patch):
+ /usr/bin/cat /builddir/build/SOURCES/binutils-2.25-version.patch
+ /usr/bin/patch -p1 -b --suffix .version~ --fuzz=0
patching file bfd/Makefile.am
patching file bfd/Makefile.in
+ echo 'Patch #5 (binutils-2.25-set-long-long.patch):'
Patch #5 (binutils-2.25-set-long-long.patch):
+ /usr/bin/cat /builddir/build/SOURCES/binutils-2.25-set-long-long.patch
+ /usr/bin/patch -p1 -b --suffix .set-long-long~ --fuzz=0
patching file bfd/configure.ac
patching file bfd/configure
Hunk #1 succeeded at 12952 (offset 133 lines).
+ echo 'Patch #6 (binutils-2.20.51.0.10-copy-osabi.patch):'
Patch #6 (binutils-2.20.51.0.10-copy-osabi.patch):
+ /usr/bin/cat /builddir/build/SOURCES/binutils-2.20.51.0.10-copy-osabi.patch
+ /usr/bin/patch -p1 -b --suffix .copy-osabi~ --fuzz=0
patching file bfd/elf.c
Hunk #1 succeeded at 1168 (offset 94 lines).
+ echo 'Patch #7 (binutils-2.20.51.0.10-sec-merge-emit.patch):'
Patch #7 (binutils-2.20.51.0.10-sec-merge-emit.patch):
+ /usr/bin/cat /builddir/build/SOURCES/binutils-2.20.51.0.10-sec-merge-emit.patch
+ /usr/bin/patch -p1 -b --suffix .sec-merge-emit~ --fuzz=0
patching file bfd/merge.c
Hunk #1 succeeded at 306 (offset -1 lines).
Hunk #2 succeeded at 326 (offset -1 lines).
Patch #8 (binutils-2.22.52.0.1-relro-on-by-default.patch):
+ echo 'Patch #8 (binutils-2.22.52.0.1-relro-on-by-default.patch):'
+ /usr/bin/cat /builddir/build/SOURCES/binutils-2.22.52.0.1-relro-on-by-default.patch
+ /usr/bin/patch -p1 -b --suffix .relro~ --fuzz=0
patching file ld/testsuite/config/default.exp
Hunk #1 succeeded at 22 (offset -1 lines).
Hunk #3 succeeded at 272 (offset -7 lines).
patching file ld/testsuite/ld-bootstrap/bootstrap.exp
Hunk #1 succeeded at 78 (offset 7 lines).
patching file ld/emultempl/elf32.em
Hunk #1 succeeded at 102 (offset -3 lines).
+ echo 'Patch #9 (binutils-2.22.52.0.1-export-demangle.h.patch):'
Patch #9 (binutils-2.22.52.0.1-export-demangle.h.patch):
+ /usr/bin/cat /builddir/build/SOURCES/binutils-2.22.52.0.1-export-demangle.h.patch
+ /usr/bin/patch -p1 -b --suffix .export-demangle-h~ --fuzz=0
patching file bfd/Makefile.am
Hunk #1 succeeded at 32 (offset 14 lines).
patching file bfd/Makefile.in
Hunk #1 succeeded at 156 (offset 18 lines).
Hunk #2 succeeded at 348 (offset 16 lines).
+ echo 'Patch #10 (binutils-2.22.52.0.4-no-config-h-check.patch):'
Patch #10 (binutils-2.22.52.0.4-no-config-h-check.patch):
+ /usr/bin/cat /builddir/build/SOURCES/binutils-2.22.52.0.4-no-config-h-check.patch
+ /usr/bin/patch -p1 -b --suffix .no-config-h-check~ --fuzz=0
patching file bfd/bfd-in.h
Hunk #1 succeeded at 23 (offset -2 lines).
patching file bfd/bfd-in2.h
Hunk #1 succeeded at 30 (offset -2 lines).
+ echo 'Patch #11 (binutils-2.23.52.0.1-addr2line-dynsymtab.patch):'
Patch #11 (binutils-2.23.52.0.1-addr2line-dynsymtab.patch):
+ /usr/bin/cat /builddir/build/SOURCES/binutils-2.23.52.0.1-addr2line-dynsymtab.patch
+ /usr/bin/patch -p1 -b --suffix .addr2line~ --fuzz=0
patching file bfd/opncls.c
Hunk #1 succeeded at 1412 (offset 115 lines).
Hunk #2 succeeded at 1434 (offset 100 lines).
Patch #12 (binutils-2.25-kernel-ld-r.patch):
+ echo 'Patch #12 (binutils-2.25-kernel-ld-r.patch):'
+ /usr/bin/cat /builddir/build/SOURCES/binutils-2.25-kernel-ld-r.patch
+ /usr/bin/patch -p1 -b --suffix .kernel-ld-r~ --fuzz=0
patching file bfd/bfd.c
patching file bfd/bfd-in2.h
Hunk #1 succeeded at 1081 (offset 3 lines).
Hunk #2 succeeded at 1656 (offset 3 lines).
Hunk #3 succeeded at 6278 (offset 3 lines).
Hunk #4 succeeded at 6463 (offset 3 lines).
Hunk #5 succeeded at 6555 (offset 3 lines).
Hunk #6 succeeded at 6770 (offset 3 lines).
patching file bfd/elf.c
Hunk #1 succeeded at 2228 (offset 20 lines).
patching file bfd/format.c
patching file bfd/opncls.c
Hunk #1 succeeded at 1715 (offset 4 lines).
patching file bfd/plugin.c
patching file bfd/plugin.h
patching file bfd/section.c
patching file binutils/objcopy.c
Hunk #3 succeeded at 2811 (offset 12 lines).
patching file binutils/readelf.c
Hunk #1 succeeded at 3658 (offset 34 lines).
patching file include/bfdlink.h
Hunk #1 succeeded at 395 (offset 6 lines).
patching file include/elf/common.h
patching file ld/emultempl/alphaelf.em
patching file ld/emultempl/armelf.em
patching file ld/emultempl/elf32.em
Hunk #2 succeeded at 1734 (offset 3 lines).
Hunk #3 succeeded at 1744 (offset 3 lines).
Hunk #4 succeeded at 1774 (offset 3 lines).
Hunk #5 succeeded at 1787 (offset 3 lines).
Hunk #6 succeeded at 1863 (offset 3 lines).
Hunk #7 succeeded at 1950 (offset 3 lines).
Hunk #8 succeeded at 2539 (offset 3 lines).
patching file ld/emultempl/ppc64elf.em
Hunk #1 succeeded at 525 (offset 3 lines).
Hunk #2 succeeded at 557 (offset 3 lines).
Hunk #3 succeeded at 879 (offset 3 lines).
patching file ld/emultempl/spuelf.em
patching file ld/ldfile.c
patching file ld/ldlang.c
Hunk #3 succeeded at 72 (offset -1 lines).
Hunk #4 succeeded at 92 (offset -3 lines).
Hunk #5 succeeded at 1229 (offset -3 lines).
Hunk #6 succeeded at 2841 (offset -12 lines).
Hunk #7 succeeded at 6693 (offset -67 lines).
Hunk #8 succeeded at 8125 (offset -67 lines).
patching file ld/ldlang.h
Hunk #1 succeeded at 512 (offset -11 lines).
Hunk #2 succeeded at 683 (offset -15 lines).
patching file ld/ldlex.h
patching file ld/ldmain.c
Hunk #3 succeeded at 315 (offset 1 line).
Hunk #4 succeeded at 437 (offset 2 lines).
Hunk #5 succeeded at 485 (offset 2 lines).
Hunk #6 succeeded at 797 (offset 2 lines).
Hunk #7 succeeded at 1192 (offset 2 lines).
Hunk #8 succeeded at 1479 (offset 2 lines).
patching file ld/ldmain.h
patching file ld/lexsup.c
patching file ld/plugin.c
patching file ld/plugin.h
patching file ld/scripttempl/armbpabi.sc
patching file ld/scripttempl/elf32sh-symbian.sc
patching file ld/scripttempl/elf64hppa.sc
patching file ld/scripttempl/elf.sc
patching file ld/scripttempl/elfxtensa.sc
patching file ld/scripttempl/mep.sc
patching file ld/scripttempl/pep.sc
patching file ld/scripttempl/pe.sc
+ echo 'Patch #13 (binutils-2.23.2-aarch64-em.patch):'
Patch #13 (binutils-2.23.2-aarch64-em.patch):
+ /usr/bin/cat /builddir/build/SOURCES/binutils-2.23.2-aarch64-em.patch
+ /usr/bin/patch -p1 -b --suffix .aarch64~ --fuzz=0
patching file ld/emultempl/aarch64elf.em
Hunk #1 succeeded at 270 (offset 6 lines).
Hunk #2 succeeded at 282 (offset 6 lines).
Hunk #3 succeeded at 426 (offset 13 lines).
Patch #15 (binutils-2.25-aarch64-fPIC-error.patch):
+ echo 'Patch #15 (binutils-2.25-aarch64-fPIC-error.patch):'
+ /usr/bin/cat /builddir/build/SOURCES/binutils-2.25-aarch64-fPIC-error.patch
+ /usr/bin/patch -p1 -b --suffix .aarch64-fpic~ --fuzz=0
patching file bfd/elfnn-aarch64.c
Hunk #1 FAILED at 4426.
Hunk #2 FAILED at 4451.
2 out of 2 hunks FAILED -- saving rejects to file bfd/elfnn-aarch64.c.rej
error: Bad exit status from /var/tmp/rpm-tmp.volrqp (%prep)
    Bad exit status from /var/tmp/rpm-tmp.volrqp (%prep)
RPM build errors:
Child return code was: 1
EXCEPTION: Command failed. See logs for output.
 # bash --login -c /usr/bin/rpmbuild -bb --target aarch64 --nodeps  /builddir/build/SPECS/binutils.spec 
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/mockbuild/trace_decorator.py", line 84, in trace
    result = func(*args, **kw)
  File "/usr/lib/python2.7/site-packages/mockbuild/util.py", line 494, in do
    raise exception.Error("Command failed. See logs for output.\n # %s" % (command,), child.returncode)
Error: Command failed. See logs for output.
 # bash --login -c /usr/bin/rpmbuild -bb --target aarch64 --nodeps  /builddir/build/SPECS/binutils.spec 
LEAVE do --> EXCEPTION RAISED

Comment 1 Nick Clifton 2015-08-04 15:53:47 UTC

Hi Peter,

  Sorry about that.  The problem should now be fixed in: binutils-2.25.1-2.fc24

Cheers
  Nick

Comment 2 Peter Robinson 2015-08-04 16:38:54 UTC

Looks good, built, thanks for the quick response.

http://arm.koji.fedoraproject.org/koji/buildinfo?buildID=306890