Bug 1250526

Summary: Review Request: perl-Iterator-Simple-Lookahead - Simple iterator with look-ahead and unget
Product: [Fedora] Fedora Reporter: Petr Pisar <ppisar>
Component: Package ReviewAssignee: Petr Šabata <psabata>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: package-review, psabata
Target Milestone: ---Keywords: Reopened
Target Release: ---Flags: psabata: fedora-review+
gwync: fedora-cvs+
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: 0.06-1.fc23 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-09-21 10:51:04 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1250447    
Bug Blocks:    

Description Petr Pisar 2015-08-05 12:12:00 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-Iterator-Simple-Lookahead/perl-Iterator-Simple-Lookahead.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Iterator-Simple-Lookahead/perl-Iterator-Simple-Lookahead-0.07-1.fc24.src.rpm
Description:
This Perl module encapsulates an iterator that allows the user to peek the Nth
element without consuming it or to push elements back to the iterated stream.

Fedora Account System Username: ppisar

Comment 1 Petr Šabata 2015-08-12 11:06:58 UTC
* Missing buildtime dependency: sed, used on line 46

* Correct EOLs of lib/Iterator/Simple/Lookahead.pm, too.

Comment 2 Petr Pisar 2015-08-24 11:09:12 UTC
(In reply to Petr Šabata from comment #1)
> * Missing buildtime dependency: sed, used on line 46
> 
I fixed it. Updated package is on the same URL.

> * Correct EOLs of lib/Iterator/Simple/Lookahead.pm, too.
I do not want to convert this file. It's a code, not a documentation. In my opinion, EOL normalization applies to documentation only.

Comment 3 Petr Šabata 2015-08-24 13:08:01 UTC
(In reply to Petr Pisar from comment #2)
> (In reply to Petr Šabata from comment #1)
> > * Missing buildtime dependency: sed, used on line 46
> > 
> I fixed it. Updated package is on the same URL.

Ack.

> > * Correct EOLs of lib/Iterator/Simple/Lookahead.pm, too.
> I do not want to convert this file. It's a code, not a documentation. In my
> opinion, EOL normalization applies to documentation only.

It's kind of both.  The file even contains more POD than Perl code :)
Anyhow, subjective and non-critical.  Approving.

Comment 4 Petr Pisar 2015-08-25 11:22:15 UTC
New Package SCM Request
=======================
Package Name: perl-Iterator-Simple-Lookahead
Short Description: Simple iterator with look-ahead and unget
Upstream URL: http://search.cpan.org/dist/Iterator-Simple-Lookahead/
Owners: ppisar jplesnik psabata
Branches: 
InitialCC: perl-sig

Comment 5 Gwyn Ciesla 2015-08-25 13:26:59 UTC
Git done (by process-git-requests).

Comment 6 Petr Pisar 2015-08-25 13:59:20 UTC
Thank you for the review and the repository.

Comment 7 Petr Pisar 2015-09-02 13:22:05 UTC
Package Change Request
======================
Package Name: perl-Iterator-Simple-Lookahead
New Branches: f23
Owners: ppisar jplesnik psabata
InitialCC: perl-sig

Comment 8 Gwyn Ciesla 2015-09-03 12:50:26 UTC
Git done (by process-git-requests).

Comment 9 Fedora Update System 2015-09-03 14:56:02 UTC
perl-Iterator-Simple-0.06-1.fc23 perl-Iterator-Simple-Lookahead-0.07-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-14985

Comment 10 Fedora Update System 2015-09-04 07:33:49 UTC
perl-Iterator-Simple-0.06-1.fc23, perl-Iterator-Simple-Lookahead-0.07-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update perl-Iterator-Simple-Lookahead perl-Iterator-Simple'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-14985

Comment 11 Fedora Update System 2015-09-21 10:50:54 UTC
perl-Iterator-Simple-0.06-1.fc23, perl-Iterator-Simple-Lookahead-0.07-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.