Bug 1251252

Summary: API documentation for kickstart.importFile (and more) refers to "RHN"
Product: Red Hat Satellite 5 Reporter: Jan Hutař <jhutar>
Component: APIAssignee: Ondrej Gajdusek <ogajduse>
Status: CLOSED CURRENTRELEASE QA Contact: Radovan Drazny <rdrazny>
Severity: low Docs Contact:
Priority: unspecified    
Version: 570CC: dyordano, ogajduse, psegedy, rdrazny, tkasparek, tlestach
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: spacewalk-java-2.5.14-20 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-06-21 12:06:25 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1358815    

Description Jan Hutař 2015-08-06 19:58:51 UTC
Description of problem:
API documentation for kickstart.importFile reffers to "RHN"


Version-Release number of selected component (if applicable):
spacewalk-java-2.3.8-108.el6sat.noarch


How reproducible:
always


Steps to Reproduce:
1. Check description on (all 3 variants of the call):
   https://<fqdn>/rhn/apidoc/handlers/KickstartHandler.jsp#importFile
   Check also:
     #createProfileWithCustomUrl
     #createProfile - in the description there is "Import a KS profile...",
                      but probably should be "Create a KS profile..."


Actual results:
Method: importFile
Description: Import a kickstart profile into RHN. 


Expected results:
Calls importRawFile below importFile have "satellite" in the description. That is not perfect as well, but is better.

Comment 1 Ondrej Gajdusek 2016-08-23 08:51:02 UTC
taking

Comment 2 Ondrej Gajdusek 2016-08-29 14:36:50 UTC
There is no way to change these names (Spacewalk, Satellite) dynamically. So I changed 'RHN' reference to 'Satellite'. Repaired in commit 6f3ece96eaa07503653a65ec1a2dd9d37543a28 .

Comment 3 Ondrej Gajdusek 2016-11-02 10:10:57 UTC
Commit I mentioned in comment #2 is incorrect. The correct hash of the commits I did are 4b3c2144dcf356c6f48e398aed6643708f8c227f for the parrent commit and a14d72eb14b1b787a650b8fb9f15fa52fbee0c9d for the child.

Comment 4 Tomas Lestach 2016-11-03 11:00:17 UTC
removing 'into Satellite' completely as:
* product name is 'Red Hat Satellite'
* it should make some sense on Spacewalk as well

spacewalk.git: eb29c1f8e5abdc77cb803c0c2e06cbfaa1c25bd6