Bug 1251587

Summary: Clean up of spec file.
Product: [Fedora] Fedora Reporter: Sergio Basto <sergio>
Component: patchutilsAssignee: Tim Waugh <twaugh>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: unspecified    
Version: rawhideCC: twaugh
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: patchutils-0.3.4-4.fc23 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-08-24 01:26:13 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Clean up spec files
none
fedora_review.patch
none
fix FTBFS on epel6 none

Description Sergio Basto 2015-08-07 19:58:49 UTC
Created attachment 1060474 [details]
Clean up spec files

Hi , 

I thought the best way was report here, small cleaning that can be made in patchutils.spec file


Version-Release number of selected component (if applicable):

patchutils-0.3.4-2.fc21.x86_64

Comment 1 Sergio Basto 2015-08-09 16:48:23 UTC
Created attachment 1060776 [details]
fedora_review.patch

Running fedora-review -n ./ , we may fix 3 minor issues in patchutils.spec 

if Obsoletes: interdiff <= 0.0.10
we should provide a bigger version ... 

Added %license tag

and
-make %{?smp_mflags}
+make %{?_smp_mflags}

Comment 2 Sergio Basto 2015-08-19 23:55:29 UTC
Created attachment 1065041 [details]
fix FTBFS on epel6

Hello , 
one little fix for epel6 and I tried aldo build on epel5 but doesn't build because tar doesn't support xz compression [1] ...

[1] 
https://copr-be.cloud.fedoraproject.org/results/sergiomb/patchutils_with_diffview/epel-5-x86_64/00108112-patchutils/build.log.gz

from 

https://copr.fedoraproject.org/coprs/sergiomb/patchutils_with_diffview/build/108112/

Comment 3 Sergio Basto 2015-08-24 01:26:13 UTC
The patches are committed [1] , we may close this report. 

Thanks, 

[1] http://pkgs.fedoraproject.org/cgit/patchutils.git/commit/?id=dd2c8dc409bf9e95d55000ca409fa91a4418eb60