Bug 1251951

Summary:	Review Request: python-discover - Test discovery for unittest. Backported from Python 2.7 for Python 2.4+
Product:	[Fedora] Fedora	Reporter:	Chandan Kumar <chkumar246>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED NOTABUG	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	chkumar, jpena, karlthered, package-review
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-08-28 13:43:43 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1243533

Description Chandan Kumar 2015-08-10 11:56:26 UTC

Spec URL: https://chandankumar.fedorapeople.org/python-discover.spec

SRPM URL: https://chandankumar.fedorapeople.org/python-discover-0.4.0-1.fc22.src.rpm

Description: This is the test discovery mechanism and load_tests protocol for unittest backported from Python 2.7 to work with Python 2.4 or more recent (including Python 3).
Fedora Account System Username: chandankumar

Successful Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=10660603

Comment 1 Javier Peña 2015-08-12 16:31:21 UTC

Hi Chandan,

You should remove the "%exclude %{python2_sitelib}/discover.py*" line, it is preventing discover.py from being packaged. Also, byte-compiled files should also be included, according to https://fedoraproject.org/wiki/Packaging:Python.

Should this package support both python2 and python3, or just python2? If so, some additional changes might be needed.

Javier

Comment 2 Chandan Kumar 2015-08-26 08:50:33 UTC

Hello Javier,

Thanks for reviewing the package.
Here is the updated spec file: https://chandankumar.fedorapeople.org/python-discover.spec

SRPM: https://chandankumar.fedorapeople.org/python-discover-0.4.0-1.fc22.src.rpm

Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=10836365

Thanks,

Chandan Kumar

Comment 3 Haïkel Guémar 2015-08-27 08:29:26 UTC

do we still need this one?

Comment 4 Chandan Kumar 2015-08-28 13:43:43 UTC

(In reply to Haïkel Guémar from comment #3)
> do we still need this one?

No longer needed, we have started removing from openstack-* packages test-requirements.

Thanks,

Chandan Kumar