Bug 1252088

Summary:	copyin of multiple files and directories gets copied to wrong destination
Product:	[Fedora] Fedora	Reporter:	pall.valmundsson
Component:	mock	Assignee:	Miroslav Suchý <msuchy>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	21	CC:	jdisnard, mebrown, msimacek, msuchy, praiskup, williams
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	1.2.13-2.fc22 mock-1.2.13-2.fc21 mock-1.2.13-2.el7 mock-1.2.13-2.el6	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-09-23 04:10:56 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description pall.valmundsson 2015-08-10 16:49:22 UTC

Description of problem:
A --copyin with multiple arguments of which at least one is a directory and not the last source file/directory will make all remaining files/directories get copied into dest_dir/argument.

Version-Release number of selected component (if applicable):
mock version: 1.2.10

How reproducible:
Always

Steps to Reproduce:
Demo #1:
touch file1.txt
mkdir dir1
mkdir dir2

mock -r epel-6-x86_64 --init
mock -r epel-6-x86_64 --copyin file1.txt dir1 dir2 /

[...]
INFO: copying file1.txt to /var/lib/mock/epel-6-x86_64/root/
INFO: copying dir1 to /var/lib/mock/epel-6-x86_64/root/
INFO: copying dir2 to /var/lib/mock/epel-6-x86_64/root/dir1
[...]

Demo #2:
mock -r epel-6-x86_64 --init
mock -r epel-6-x86_64 --copyin dir1 dir2 file1.txt /

[...]
INFO: copying dir1 to /var/lib/mock/epel-6-x86_64/root/
INFO: copying dir2 to /var/lib/mock/epel-6-x86_64/root/dir1
INFO: copying file1.txt to /var/lib/mock/epel-6-x86_64/root/dir1/dir2
[...]

Actual results:
See log snips above.

Expected results:
All source files/directories are copied into the supplied destination directory.

Additional info:
https://git.fedorahosted.org/cgit/mock.git/tree/py/mock.py?id=abacd959a3bde13ff60311a4a77c32fe0fd88b34#n754

The "dest" variable is overwritten with a new base directory which gets reused for the next file in line.

Comment 1 Miroslav Suchý 2015-08-19 10:05:28 UTC

Fixed in commit:
* 146ebf8 (origin/devel) copy files to correct location [RHBZ#1252088]

Comment 2 Fedora Update System 2015-09-16 20:02:01 UTC

mock-1.2.13-2.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-16053

Comment 3 Fedora Update System 2015-09-16 20:04:59 UTC

mock-1.2.13-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-16054

Comment 4 Fedora Update System 2015-09-16 20:06:58 UTC

mock-1.2.13-2.fc21 has been submitted as an update to Fedora 21. https://bodhi.fedoraproject.org/updates/FEDORA-2015-16056

Comment 5 Fedora Update System 2015-09-16 20:08:42 UTC

mock-1.2.13-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8114

Comment 6 Fedora Update System 2015-09-16 20:09:47 UTC

mock-1.2.13-2.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8115

Comment 7 Fedora Update System 2015-09-17 21:30:10 UTC

mock-1.2.13-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update mock'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-16054

Comment 8 Fedora Update System 2015-09-18 05:21:04 UTC

mock-1.2.13-2.fc21 has been pushed to the Fedora 21 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update mock'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-16056

Comment 9 Fedora Update System 2015-09-18 16:24:31 UTC

mock-1.2.13-2.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update mock'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-16053

Comment 10 Fedora Update System 2015-09-19 03:19:58 UTC

mock-1.2.13-2.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update mock'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8115

Comment 11 Fedora Update System 2015-09-19 03:21:48 UTC

mock-1.2.13-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update mock'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8114

Comment 12 Fedora Update System 2015-09-23 04:09:50 UTC

mock-1.2.13-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Comment 13 Fedora Update System 2015-09-24 08:22:48 UTC

mock-1.2.13-2.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.

Comment 14 Fedora Update System 2015-10-05 22:50:41 UTC

mock-1.2.13-2.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report.

Comment 15 Fedora Update System 2015-10-07 03:05:10 UTC

mock-1.2.13-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.

Comment 16 Fedora Update System 2015-10-07 04:05:07 UTC

mock-1.2.13-2.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.