Bug 1252140

Summary: twisted/plugins shipped by python-twisted
Product: [Fedora] Fedora Reporter: Julien Enselme <jujens>
Component: python-twistedAssignee: Thomas Vander Stichele <thomas>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 24CC: jamielinux, jonathansteffan, matthias, piotr1212, thomas, tom.prince, zbyszek
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-06-26 20:38:10 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1244522    

Description Julien Enselme 2015-08-10 19:48:04 UTC
Hi,

I am in the process of packaging python-autobahn (http://autobahn.ws/, https://bugzilla.redhat.com/show_bug.cgi?id=1244522). Today, I run fedora-review on my package to see what I could improve in my package and it reported:

[ ]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/lib/python2.7/site-
     packages/twisted(python-carbon), /usr/lib/python2.7/site-
     packages/twisted/plugins(python-carbon)

It seems that we both need to place files in /usr/lib/python2.7/site-packages/twisted/plugins (I also need /usr/lib/python3.4/site-packages/twisted/plugins).

I think that the easiest way to solve this problem is to create a pytho-twisted-plugin package that would own /usr/lib/python2.7/site-packages/twisted (same for python3 + __pycache__) and /usr/lib/python2.7/site-packages/twisted/plugins and then make our packages require it. I don't expect conflict within the directory since our packages have different name.

What do you think?

Comment 1 Piotr Popieluch 2015-08-11 20:40:22 UTC
Wouldn't it be easier to add the directory it to the python-twisted package. So we won't have to create empty packages and go through the review process.

Are you also planning to package autobahn in epel?

Jonathan, what do you, as maintainer of python-twisted, think?

Comment 2 Julien Enselme 2015-08-12 20:03:50 UTC
> Wouldn't it be easier to add the directory it to the python-twisted package. So we won't have to create empty packages and go through the review process.

It may. I admit I haven't thought of that.

> Are you also planning to package autobahn in epel?

Nope

Comment 3 Zbigniew Jędrzejewski-Szmek 2015-08-13 03:08:53 UTC
FWIW, I think that having this directory co-owned by various plugin packages is fine. Adding the directory to python-twisted is also OK.

Comment 4 Jonathan Steffan 2015-08-15 16:11:57 UTC
I think it makes the most sense to create and own this directory in python-twisted.

Comment 5 Jonathan Steffan 2015-08-15 16:21:00 UTC
I will add this directory when I fix https://bugzilla.redhat.com/show_bug.cgi?id=1222954

Comment 6 Julien Enselme 2015-08-15 17:15:13 UTC
@Jonathan: sounds good. Keep me posted so I can update my package.

Comment 7 Julien Enselme 2015-11-27 12:47:11 UTC
Hi,

Any progress on that issue?

Comment 8 Jan Kurik 2016-02-24 13:36:19 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 24 development cycle.
Changing version to '24'.

More information and reason for this action is here:
https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora24#Rawhide_Rebase

Comment 9 Jonathan Steffan 2016-06-26 20:38:10 UTC
This directory is now owned by the package.