Bug 1252297
| Summary: | Quota: volume-reset shouldn't remove quota-deem-statfs, unless explicitly specified, when quota is enabled. | ||
|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | Manikandan <mselvaga> |
| Component: | quota | Assignee: | Manikandan <mselvaga> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | |
| Severity: | unspecified | Docs Contact: | |
| Priority: | medium | ||
| Version: | 3.7.3 | CC: | bugs, gluster-bugs, grajaiya, mselvaga, rgowdapp, smohan, spandit, storage-qa-internal, vbellur, vmallika |
| Target Milestone: | --- | Keywords: | EasyFix, ZStream |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | glusterfs-3.7.4 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | 1250582 | Environment: | |
| Last Closed: | 2015-09-09 09:39:23 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1027723, 1250582 | ||
| Bug Blocks: | 1211860 | ||
|
Comment 1
Anand Avati
2015-08-11 07:26:14 UTC
REVIEW: http://review.gluster.org/11879 (quota : volume-reset shouldn't remove quota-deem-statfs) posted (#2) for review on release-3.7 by Manikandan Selvaganesh (mselvaga) COMMIT: http://review.gluster.org/11879 committed in release-3.7 by Raghavendra G (rgowdapp) ------ commit 13061c8006471c87ff92007c8decc5586c600f0f Author: Manikandan Selvaganesh <mselvaga> Date: Wed Aug 5 19:23:01 2015 +0530 quota : volume-reset shouldn't remove quota-deem-statfs Volume-reset shouldn't remove quota-deem-statfs, unless explicitly specified, when quota is enabled. 1) glusterd_op_stage_reset_volume () 'gluster volume set/reset <VOLNAME>' features.quota/ features.inode-quota' should not be allowed as it is deprecated. Setting and resetting quota/inode-quota features should be allowed only through 'gluster volume quota <VOLNAME> enable/disable'. 2) glusterd_enable_default_options () Option 'features.quota-deem-statfs' should not be turned off with 'gluster volume reset <VOLNAME>', since quota features can be set/reset only with 'gluster volume quota <VOLNAME> enable/disable'. But, 'gluster volume set features.quota-deem-statfs' can be turned on/off when quota is enabled. Backport of http://review.gluster.org/#/c/11839/ Cherry picked from commit 1868be8a5c309da8d516624d4af3b3b97819a9eb > Change-Id: Ib5aa00a4d8c82819c08dfc23e2a86f43ebc436c4 > BUG: 1250582 > Signed-off-by: Manikandan Selvaganesh <mselvaga> > Reviewed-on: http://review.gluster.org/11839 > Tested-by: NetBSD Build System <jenkins.org> > Tested-by: Gluster Build System <jenkins.com> > Reviewed-by: Vijaikumar Mallikarjuna <vmallika> > Reviewed-by: Atin Mukherjee <amukherj> Change-Id: Ib5aa00a4d8c82819c08dfc23e2a86f43ebc436c4 BUG: 1252297 Signed-off-by: Manikandan Selvaganesh <mselvaga> Reviewed-on: http://review.gluster.org/11879 Tested-by: NetBSD Build System <jenkins.org> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Raghavendra G <rgowdapp> *** Bug 1211860 has been marked as a duplicate of this bug. *** This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.4, please open a new bug report. glusterfs-3.7.4 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/12496 [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user |