Bug 1252923

Summary: qemucmdline: Avoid duplication of qemu-kvm flags
Product: [oVirt] vdsm Reporter: Douglas Schilling Landgraf <dougsland>
Component: GeneralAssignee: Dan Kenigsberg <danken>
Status: CLOSED CANTFIX QA Contact: Lukas Svaty <lsvaty>
Severity: high Docs Contact:
Priority: medium    
Version: ---CC: bazulay, bugs, jsuchane, lsurette, mgoldboi, michal.skrivanek, mtessun, rbalakri, sbonazzo, srevivo, vchoudha, ycui, ykaul
Target Milestone: ovirt-4.2.0Flags: michal.skrivanek: ovirt-4.2?
rule-engine: planning_ack?
rule-engine: devel_ack?
rule-engine: testing_ack?
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-08-21 08:30:09 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Virt RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1029226    
Bug Blocks:    

Description Douglas Schilling Landgraf 2015-08-12 13:55:53 UTC 
Description of problem:

After configuring qemucmdline hook and setup additional options to spice it adds to qemu-kvm two spice flags. Please start the virtual machine with only one -spice option having all parameters.

VDSM must avoid the duplication for starting correctly the virtual machine.

How reproducible:

1. Install qemucmdline hook in the host
   https://apps.fedoraproject.org/packages/vdsm-hook-qemucmdline or 
   http://resources.ovirt.org/pub/


2. In the Engine
 # engine-config -s "UserDefinedVMProperties=qemu_cmdline=^.*$"
 # service ovirt-engine restart

Now go to oVirt Engine Admin Portal
   -> Virtual Machines
   -> Stop the virtual machine
   -> Click in the VM and Edit
      -> Custom Properties
         Add the key qemu_cmdline and type in the box your additional param to qemu:
  Example:
           ["-spice", "tls-ciphers=DES-CBC3-SHA"]
   -> Start the virtual machine

3. In the host.

   ps auxww | grep qemu-kvm  and will see two -spice options.

Additional Note

Probably it happens not only with spice but with the others options.
Comment 1 Michal Skrivanek 2015-08-12 14:21:26 UTC 
note this is currently not possible.
There are libvirt hooks which also can't modify qemu command line, unfortunately

The only way seem to be to wrap /usr/libexec/qemu-kvm-rhev and alter arguments there
Comment 4 Michal Skrivanek 2016-01-22 07:06:41 UTC 
The only current use case I'm aware of is to supply allowed ciphers list. Feature bug 1029226 should solve it at system level
Comment 11 Michal Skrivanek 2017-08-21 08:30:09 UTC 
need to rely on hook and custom wrapper (https://github.com/dougsland/misc-ovirt/tree/master/ovirt-qemu-kvm-wrapper) for the timebeing