Bug 1253318
| Summary: | [abrt] [beaker] [master] Error sending message: The connection is closed | ||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Lubomir Rintel <lrintel> | ||||||||||||||||||||||||
| Component: | NetworkManager | Assignee: | Rashid Khan <rkhan> | ||||||||||||||||||||||||
| Status: | CLOSED NOTABUG | QA Contact: | Desktop QE <desktop-qa-list> | ||||||||||||||||||||||||
| Severity: | medium | Docs Contact: | |||||||||||||||||||||||||
| Priority: | medium | ||||||||||||||||||||||||||
| Version: | 7.3 | CC: | danw, dcbw, jklimes, lrintel, rkhan, thaller | ||||||||||||||||||||||||
| Target Milestone: | rc | ||||||||||||||||||||||||||
| Target Release: | --- | ||||||||||||||||||||||||||
| Hardware: | x86_64 | ||||||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||||||
| Whiteboard: | abrt_hash:d3581ec7b8e3f234f554a8b330e0ac037b3f870b | ||||||||||||||||||||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||||||||||||||||||||
| Doc Text: | Story Points: | --- | |||||||||||||||||||||||||
| Clone Of: | Environment: | ||||||||||||||||||||||||||
| Last Closed: | 2015-08-19 20:42:53 UTC | Type: | --- | ||||||||||||||||||||||||
| Regression: | --- | Mount Type: | --- | ||||||||||||||||||||||||
| Documentation: | --- | CRM: | |||||||||||||||||||||||||
| Verified Versions: | Category: | --- | |||||||||||||||||||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||||||||||||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||||||||||||||||||
| Embargoed: | |||||||||||||||||||||||||||
| Bug Depends On: | 1255169, 1266470 | ||||||||||||||||||||||||||
| Bug Blocks: | |||||||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||||||
|
Description
Lubomir Rintel
2015-08-13 13:24:59 UTC
Created attachment 1062543 [details]
File: backtrace
Created attachment 1062544 [details]
File: cgroup
Created attachment 1062545 [details]
File: core_backtrace
Created attachment 1062546 [details]
File: dso_list
Created attachment 1062547 [details]
File: environ
Created attachment 1062548 [details]
File: limits
Created attachment 1062549 [details]
File: machineid
Created attachment 1062550 [details]
File: maps
Created attachment 1062551 [details]
File: open_fds
Created attachment 1062552 [details]
File: proc_pid_status
Created attachment 1062553 [details]
File: var_log_messages
I don't see the reason for this warning.
Looking at g_dbus_method_invocation_return_value_internal() in glib/gio/gdbusmethodinvocation.c:
error = NULL;
if (!g_dbus_connection_send_message (g_dbus_method_invocation_get_connection (invocation), reply, G_DBUS_SEND_MESSAGE_FLAGS_NONE, NULL, &error))
{
g_warning ("Error sending message: %s", error->message);
g_error_free (error);
}
Seems like a glib bug to me.
CC-ing danw
I guess the assumption is that errors shouldn't normally occur there, and if they do, there's not really anything the caller could do about it, so it doesn't make sense to return a GError to the caller, but at the same time, if something does go wrong, we need to let the programmer know somehow... In this particular case though (G_IO_ERROR_CLOSED), the warning isn't at all useful, and due to the multi-threadedness of gdbus, I don't even think you can completely reliably prevent it by checking g_dbus_connection_is_closed() before g_method_invocation_return_value(). (Though NM could do that anyway to *mostly* get rid of it) So probably glib should skip the warning in this case. (The warning could be hit from any D-Bus method return that might be on a private connection... which I think means every D-Bus method return in the daemon.) filed https://bugzilla.gnome.org/show_bug.cgi?id=753839 for the glib issue I'm closing this one. It's not really a NM issue. Once bug 1255169 is fixed, this will be obsolete. |