Bug 1253607

Summary:	gluster snapshot status --xml gives back unexpected non xml output
Product:	[Community] GlusterFS	Reporter:	Avra Sengupta <asengupt>
Component:	snapshot	Assignee:	Avra Sengupta <asengupt>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	3.7.3	CC:	amukherj, bugs, gluster-bugs, kauffman, rjoseph
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	glusterfs-3.7.4	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1245895	Environment:
Last Closed:	2015-09-09 09:39:51 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1218732, 1245895
Bug Blocks:	1245897

Description Avra Sengupta 2015-08-14 08:58:29 UTC

+++ This bug was initially created as a clone of Bug #1245895 +++

+++ This bug was initially created as a clone of Bug #1218732 +++

Description of problem:
Command 'gluster snapshot status --xml' outputs text that is not part of the xml. This inconsistency breaks my code which only has a reason to expect xml data as input.

Version-Release number of selected component (if applicable):
Seen in 3.6.2.

How reproducible:
Always.

Steps to Reproduce: 
1. Create at least a 2 node cluster.
2. Create 1 volume.
3. Make sure you don't have any snapshots.

Actual results:
root@gfs-test-1:~# gluster snapshot status --xml
No snapshots present
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<cliOutput>
  <opRet>0</opRet>
  <opErrno>0</opErrno>
  <opErrstr>(null)</opErrstr>
  <snapStatus>
    <snapshots/>
  </snapStatus>
</cliOutput> 

Expected results:
root@gfs-test-1:~# gluster snapshot status --xml
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<cliOutput>
  <opRet>0</opRet>
  <opErrno>0</opErrno>
  <opErrstr>(null)</opErrstr>
  <snapStatus>
    <snapshots/>
  </snapStatus>
</cliOutput> 


Additional info:
Is this 'null' in the output on purpose? 
  <opErrstr>(null)</opErrstr> 
Other commands like 'gluster snapshot info --xml' show '<opErrstr/>'.


I am marking this as high priority since I parse this output and expect the output to be consistent.

--- Additional comment from Anand Avati on 2015-08-05 07:12:35 EDT ---

REVIEW: http://review.gluster.org/11835 (xml output: Fix non-uniform opErrstr xml output) posted (#1) for review on master by Avra Sengupta (asengupt)

--- Additional comment from Anand Avati on 2015-08-12 04:26:58 EDT ---

REVIEW: http://review.gluster.org/11835 (xml output: Fix non-uniform opErrstr xml output) posted (#2) for review on master by Avra Sengupta (asengupt)

Comment 1 Anand Avati 2015-08-14 08:59:29 UTC

REVIEW: http://review.gluster.org/11920 (xml output: Fix non-uniform opErrstr xml output) posted (#1) for review on release-3.7 by Avra Sengupta (asengupt)

Comment 2 Anand Avati 2015-08-18 07:00:41 UTC

COMMIT: http://review.gluster.org/11920 committed in release-3.7 by Rajesh Joseph (rjoseph) 
------
commit cc0ba2ad47aa9d023f823cced9047a2287a990b4
Author: Avra Sengupta <asengupt>
Date:   Wed Aug 5 16:36:06 2015 +0530

    xml output: Fix non-uniform opErrstr xml output
    
        Backport of http://review.gluster.org/#/c/11835/
    
    Display <opErrstr/> in case of no operrstr for
    all xml output of gluster commands.
    
    Change-Id: Ie16f749f90b4642357c562012408c434cd38661f
    BUG: 1253607
    Signed-off-by: Avra Sengupta <asengupt>
    Reviewed-on: http://review.gluster.org/11920
    Tested-by: NetBSD Build System <jenkins.org>
    Reviewed-by: Rajesh Joseph <rjoseph>

Comment 3 Kaushal 2015-09-09 09:39:51 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.4, please open a new bug report.

glusterfs-3.7.4 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/12496
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user