Bug 1254167

Summary:	`gluster volume heal <vol-name> split-brain' changes required for entry-split-brain
Product:	[Community] GlusterFS	Reporter:	Ravishankar N <ravishankar>
Component:	replicate	Assignee:	Ravishankar N <ravishankar>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	mainline	Keywords:	Reopened, Triaged
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.8rc2	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1234399
Clones:	1256605 (view as bug list)		Environment:
Last Closed:	2016-06-16 13:32:25 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1234399
Bug Blocks:	1256605

Description Ravishankar N 2015-08-17 10:35:41 UTC

Description of problem:
------------------------

`gluster volume heal <vol-name> split-brain' command today has 2 arguments: bigger-file and source-brick. 

In case of a directory entry split-brain, the argument bigger-file is not meaningful and should not be accepted. The user needs to be notified that this option cannot be used with directories. Currently, this argument causes entry split-brain to be healed by conservative merge, without any complaints.

For the source-brick argument, the user should be notified that it is conservative merge that will be performed for the directory in question and the heal should happen.

Version-Release number of selected component (if applicable):
--------------------------------------------------------------
glusterfs-3.7.1-3.el6rhs.x86_64

How reproducible:
------------------
Always


Steps to Reproduce:
--------------------
1. On a directory in entry split-brain, run the `gluster volume heal <vol-name> split-brain' command with each of the 2 arguments.

Actual results:
----------------
Heal happens in both cases without notifying the user, as explained in description.

Expected results:
------------------
User should be notified in case the bigger-file argument is used to heal directory entry split-brain, that this is not applicable to directories. In case of source-brick argument, perform conservative merge and notify the user accordingly.

Comment 1 Ravishankar N 2015-08-17 10:39:25 UTC

Patch @ http://review.gluster.org/11937

Comment 2 Anand Avati 2015-08-21 07:31:16 UTC

REVIEW: http://review.gluster.org/11937 (heal: Add check for healing directories in split-brain) posted (#2) for review on master by Ravishankar N (ravishankar)

Comment 3 Anand Avati 2015-08-24 12:17:08 UTC

REVIEW: http://review.gluster.org/11937 (heal: Add check for healing directories in split-brain) posted (#3) for review on master by Ravishankar N (ravishankar)

Comment 4 Anand Avati 2015-08-25 05:45:13 UTC

COMMIT: http://review.gluster.org/11937 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit 97bae6371b5e841f03a61d6700033f40afd5cdc7
Author: Ravishankar N <ravishankar>
Date:   Mon Aug 17 10:29:19 2015 +0000

    heal: Add check for healing directories in split-brain
    
    1. Healing using  `bigger-file' option does not make much sense for directories,
    hence disallow it and notify the user.
    2. Healing using 'source-brick' option for directories performs a conservative
    merge. Notify the user about it.
    
    Change-Id: I0acff7b438bdb256615ed0f40d45694f37a77dd5
    BUG: 1254167
    Signed-off-by: Ravishankar N <ravishankar>
    Reviewed-on: http://review.gluster.org/11937
    Tested-by: NetBSD Build System <jenkins.org>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>

Comment 5 Nagaprasad Sathyanarayana 2015-10-25 15:11:41 UTC

Fix for this BZ is already present in a GlusterFS release. You can find clone of this BZ, fixed in a GlusterFS release and closed. Hence closing this mainline BZ as well.

Comment 6 Niels de Vos 2016-06-16 13:32:25 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user