Bug 1254494

REVIEW: http://review.gluster.org/11949 (common-ha : refresh-config should print sensible output) posted (#1) for review on release-3.7 by Meghana M (mmadhusu)

REVIEW: http://review.gluster.org/11949 (common-ha : refresh-config should print sensible output) posted (#2) for review on release-3.7 by Meghana M (mmadhusu)

REVIEW: http://review.gluster.org/11949 (common-ha : refresh-config should print sensible output) posted (#3) for review on release-3.7 by Meghana M (mmadhusu)

COMMIT: http://review.gluster.org/11949 committed in release-3.7 by Kaleb KEITHLEY (kkeithle) 
------
commit d7adcca24fb9638df2806c01d8ea7e73eec46928
Author: Meghana M <mmadhusu>
Date:   Wed Aug 12 14:48:39 2015 +0530

    common-ha : refresh-config should print sensible output
    
    ganesha-ha.sh --refresh-config printed the dbus-send output
    messages as is on the console. Improving the output
    of the operation by redirecting the messages to /var/log/messages
    and by checking the exit code of the command executed.
    
    The behaviour is also changed a litlle by exiting
    when refresh-config fails on any of the nodes.
    We don't want to continue changing config files
    on other nodes when refresh-config has already failed
    on one of the nodes.
    
    Change-Id: Ic2e4e26bc09b1ba23cc6b62a1590c6083a0bde80
    BUG: 1254494
    Signed-off-by: Meghana M <mmadhusu>
    Reviewed-on: http://review.gluster.org/11949
    Reviewed-by: soumya k <skoduri>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Kaleb KEITHLEY <kkeithle>
    Tested-by: NetBSD Build System <jenkins.org>

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.4, please open a new bug report.

glusterfs-3.7.4 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/12496
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

REVIEW: http://review.gluster.org/12439 (common-ha: Corrected refresh-config output parsing) posted (#1) for review on release-3.7 by soumya k (skoduri)

REVIEW: http://review.gluster.org/12439 (common-ha: Corrected refresh-config output parsing) posted (#2) for review on release-3.7 by soumya k (skoduri)

REVIEW: http://review.gluster.org/12439 (common-ha: Corrected refresh-config output parsing) posted (#3) for review on release-3.7 by soumya k (skoduri)

REVIEW: http://review.gluster.org/13719 (common-ha : refresh-config should print sensible output) posted (#1) for review on master by Kaleb KEITHLEY (kkeithle)

REVIEW: http://review.gluster.org/13724 (common-ha: Corrected refresh-config output parsing) posted (#1) for review on master by Kaleb KEITHLEY (kkeithle)

COMMIT: http://review.gluster.org/13719 committed in master by Kaleb KEITHLEY (kkeithle) 
------
commit dd1201e01f7f3cd86992f57f9b46f476bdb43d8c
Author: Meghana M <mmadhusu>
Date:   Wed Aug 12 14:48:39 2015 +0530

    common-ha : refresh-config should print sensible output
    
    ganesha-ha.sh --refresh-config printed the dbus-send output
    messages as is on the console. Improving the output
    of the operation by redirecting the messages to /var/log/messages
    and by checking the exit code of the command executed.
    
    The behaviour is also changed a litlle by exiting
    when refresh-config fails on any of the nodes.
    We don't want to continue changing config files
    on other nodes when refresh-config has already failed
    on one of the nodes.
    
    BUG: 1254494
    Change-Id: I33a1c0f750695135118b4ad4d5fa038b27bc7fec
    Signed-off-by: Meghana M <mmadhusu>
    Reviewed-on: http://review.gluster.org/11949
    Reviewed-by: soumya k <skoduri>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Kaleb KEITHLEY <kkeithle>
    Tested-by: NetBSD Build System <jenkins.org>
    Reviewed-on: http://review.gluster.org/13719
    Tested-by: Kaleb KEITHLEY <kkeithle>
    Smoke: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>

COMMIT: http://review.gluster.org/13724 committed in master by Kaleb KEITHLEY (kkeithle) 
------
commit 7240923a55eab2fc237d951ec0d89c51676a2aae
Author: Soumya Koduri <skoduri>
Date:   Wed Oct 28 14:50:55 2015 +0530

    common-ha: Corrected refresh-config output parsing
    
    >>>> Sample program with the earlier changes -
    output=$(dbus-send --print-reply --system \
    --dest=org.ganesha.nfsd /org/ganesha/nfsd/ExportMgr \
    org.ganesha.nfsd.exportmgr.RemoveExport uint16:5 2>&1\
      | grep -v "^method return")
    ret=$?
    echo "${output}"
    echo $ret
    sleep 1
    output=$(dbus-send --system --dest=org.ganesha.nfsd \
    /org/ganesha/nfsd/ExportMgr org.ganesha.nfsd.exportmgr.AddExport \
    string:/usr/etc/ganesha/exports/export.vol3.conf \
    string:"EXPORT(Path=/vol3)" 2>&1  | grep -v "^method return")
    ret=$?
    echo "${output}"
    echo $ret
    
    Output:
    
    1
    
    1
    
    Even if the command was successfully executed, 'grep -v' has
    filtered out the output.
    
    >>>> Sample program with the current changes -
    
    output=$(dbus-send --print-reply --system --dest=org.ganesha.nfsd \
    /org/ganesha/nfsd/ExportMgr org.ganesha.nfsd.exportmgr.RemoveExport\
     uint16:5 2>&1)
    ret=$?
    echo "${output}"
    echo $ret
    sleep 1
    output=$(dbus-send --print-reply --system --dest=org.ganesha.nfsd \
    /org/ganesha/nfsd/ExportMgr org.ganesha.nfsd.exportmgr.AddExport \
    string:/usr/etc/ganesha/exports/export.vol3.conf \
    string:"EXPORT(Path=/vol3)" 2>&1)
    ret=$?
    echo "${output}"
    echo $ret
    
    Output:
    method return sender=:1.155 -> dest=:1.174 reply_serial=2
    0
    method return sender=:1.155 -> dest=:1.175 reply_serial=2
       string "1 exports added"
    0
    
    BUG: 1254494
    Change-Id: I44fbe32588ec11f087c8b99b2d55ed55ba73727c
    Signed-off-by: Soumya Koduri <skoduri>
    Reviewed-on: http://review.gluster.org/12439
    Tested-by: NetBSD Build System <jenkins.org>
    Reviewed-by: jiffin tony Thottan <jthottan>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Kaleb KEITHLEY <kkeithle>
    Reviewed-on: http://review.gluster.org/13724
    Tested-by: Kaleb KEITHLEY <kkeithle>
    Smoke: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user