Bug 1254503
Summary: | fuse: check return value of setuid | ||
---|---|---|---|
Product: | [Community] GlusterFS | Reporter: | Prasanna Kumar Kalever <prasanna.kalever> |
Component: | fuse | Assignee: | Prasanna Kumar Kalever <prasanna.kalever> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | 3.7.3 | CC: | bugs, gluster-bugs, ndevos |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | glusterfs-3.7.4 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | 1221490 | Environment: | |
Last Closed: | 2015-09-09 09:40:07 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 1221490 | ||
Bug Blocks: | 1254488 |
Description
Prasanna Kumar Kalever
2015-08-18 09:32:49 UTC
Backport posted: http://review.gluster.org/11950 REVIEW: http://review.gluster.org/11950 (fuse: fix return value check for setuid) posted (#5) for review on release-3.7 by Niels de Vos (ndevos) COMMIT: http://review.gluster.org/11950 committed in release-3.7 by Niels de Vos (ndevos) ------ commit 5137feb6e0ab6c9b0aad1e8410397243e9f2619c Author: Prasanna Kumar Kalever <prasanna.kalever> Date: Thu May 14 12:10:01 2015 +0530 fuse: fix return value check for setuid setuid() sets the effective user ID of the calling process. If the effective UID of the caller is root, the real UID and saved set-user-ID are also set. On success, zero is returned. On error, -1 is returned, and errno is set appropriately. there are cases where setuid() can fail even when the caller is UID 0; it is a grave security error to omit checking for a failure return from setuid(). if an environment limits the number of processes a user can have, setuid() might fail if the target uid already is at the limit. Fix is to check return value of setuid. Backport: >Change-Id: I7aa5ab5e347603c69dc93188417cc4f4c81ffc75 >BUG: 1221490 >Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever> >Reviewed-on: http://review.gluster.org/10780 >Reviewed-by: Prasanna Kumar Kalever >Tested-by: Prasanna Kumar Kalever >Reviewed-by: Niels de Vos <ndevos> >Tested-by: Gluster Build System <jenkins.com> >Reviewed-by: Gaurav Kumar Garg <ggarg> >(cherry picked from commit b5ceb1a9de9af563b0f91e2a3138fa5a95cad9f6) Change-Id: I5643ccecb56ea1d3c16de57bace3f5481931a539 BUG: 1254503 Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever> Reviewed-on: http://review.gluster.org/11950 Reviewed-by: Niels de Vos <ndevos> Tested-by: Gluster Build System <jenkins.com> Tested-by: NetBSD Build System <jenkins.org> This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.4, please open a new bug report. glusterfs-3.7.4 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/12496 [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user |