Bug 1254799

Summary:	Review Request: pgbadger - A fast PostgreSQL log analyzer
Product:	[Fedora] Fedora	Reporter:	Devrim Gündüz <devrim>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED NOTABUG	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	e, jakub.jedelsky, package-review, pahan
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-08-10 00:52:16 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	201449

Description Devrim Gündüz 2015-08-18 21:47:55 UTC

Spec URL: http://www.gunduz.org/epel/pgbadger.spec
SRPM URL: http://www.gunduz.org/epel/pgbadger-7.1-1.f22.src.rpm

Description:

pgBadger is a PostgreSQL log analyzer build for speed with fully
detailed reports from your PostgreSQL log file. It's a single and small
Perl script that aims to replace and outperform the old php script
pgFouine.

pgBadger is written in pure Perl language. It uses a javascript library
to draw graphs so that you don't need additional Perl modules or any
other package to install. Furthermore, this library gives us more
features such as zooming.

pgBadger is able to autodetect your log file format (syslog, stderr or
csvlog). It is designed to parse huge log files as well as gzip
compressed file.

Fedora Account System Username: devrim

Comment 1 Eduardo Mayorga 2016-09-30 16:45:52 UTC

SRPM URL returns 404 Not Found.

Comment 2 Devrim Gündüz 2016-09-30 16:58:01 UTC

(In reply to Eduardo Mayorga from comment #1)
> SRPM URL returns 404 Not Found.

Updated to 9.0:

Spec URL: https://devrim.fedorapeople.org/pgbadger/pgbadger.spec
SRPM URL: https://devrim.fedorapeople.org/pgbadger/pgbadger-9.0-1.f24.src.rpm

Thanks!

Regards, Devrim

Comment 3 jakub.jedelsky 2017-04-13 09:44:51 UTC

Hi,

there are missing dependencies in the spec file. You have to add (at least):

BuildRequires: perl
BuildRequires: perl-ExtUtils-MakeMaker
Requires: perl

Comment 4 jakub.jedelsky 2017-04-13 10:12:37 UTC

Another observation - pgBadger uses and includes(!) bootstrap.css, some fancy fonts and JS libraries (jqplot, jquery). 

1. please check, if it's possible to bundle them together or is better to split it somehow. I'm not the expert for that. There is some note, that fonts should be packaged standalone (font Awesome is in fedora already, so you can add it as a dependency and drop it from package).

https://fedoraproject.org/wiki/Packaging:Guidelines#Avoid_bundling_of_fonts_in_other_packages

2. It looks that these css, js libraries have different licenses, so you should mention them with License tag.

https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#Multiple_Licensing_Scenarios for more details.

Thanks for the work, I'm looking forward to have the package in repos :)

Comment 5 Devrim Gündüz 2017-04-13 10:17:17 UTC

(In reply to Jakub Jedelsky from comment #3)
> Hi,
> 
> there are missing dependencies in the spec file. You have to add (at least):
> 
> BuildRequires: perl
> BuildRequires: perl-ExtUtils-MakeMaker
> Requires: perl

Thanks, done, and also updated to 9.1:

Spec URL: https://devrim.fedorapeople.org/pgbadger/pgbadger.spec
SRPM URL: https://devrim.fedorapeople.org/pgbadger/pgbadger-9.1-1.fc25.src.rpm

Regards, Devrim

Comment 6 Package Review 2020-07-10 00:52:31 UTC

This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.

Comment 7 Package Review 2020-08-10 00:52:16 UTC

This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.