Bug 1255163
Summary: | Review Request: ChessPP - Recreation of the classic game of chess using the C++ programming language | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Raphael Groner <projects.rg> |
Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | kevin, lupinix.fedora, package-review |
Target Milestone: | --- | Keywords: | FutureFeature |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | NotReady | ||
Fixed In Version: | Doc Type: | Enhancement | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2015-12-17 16:29:36 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 182235, 201449 |
Description
Raphael Groner
2015-08-19 19:55:41 UTC
Please clarify licensing before you go on! License tag in spec: # guessing something cause no license provided, https://github.com/oedead26/ChessPP/issues/1 License: MIT Very bad (even no) solution Question to FE-Legal: If upstream does not mention any explicit license, can we assume allowness to (re-)distribute as MIT or GPLv3+ generally? But let's wait what upstream says. ""Generally speaking, the absence of a license means that the default copyright laws apply. This means that you retain all rights to your source code and that nobody else may reproduce, distribute, or create derivative works from your work. This might not be what you intend. Even if this is what you intend, if you publish your source code in a public repository on GitHub, you have accepted the Terms of Service which do allow other GitHub users some rights. Specifically, you allow others to view and fork your repository."" https://help.github.com/articles/open-source-licensing/ No license = non-free, sorry. (And even the repository for non-free stuff will not want to touch this without a clear permission to redistribute.) You need to contact the upstream author requesting the specification of a Free Software license (and while you are at it, also the inclusion of build scripts – README.md talks about using qmake, but I can't find the .pro file; it shouldn't really be the packager's job to write a CMakeLists.txt as you did). I see from the comments in the specfile that there are already GitHub issues filed for those issues, so all you can do now is wait for upstream to address at least the licensing one. Okay, I've removed the files from fedorapeople.org and wait for upstream feedback about license clarification in the reported issue [1]. [1] https://github.com/oedead26/ChessPP/issues/1 Not sure what is meant with qmake, I think using cmake is good. The guess is that upstream development happens on a Redmond OS cause the source is using some functionality that's available there only but could be patched and I'm going to do so with an comparable but more standardized replacement. I'm mentioning qmake because their README.md says:
> Usage
> Either download one of the precompiled binaries (for x86 or x64 Windows
> machines) or compile the source code using qmake. The program is
> cross-platform.
But I cannot find any qmake .pro file either. There are no build scripts of any kind in their GitHub repository, at least none that I can find.
> Not sure what is meant with qmake, I think using cmake is good. The guess is
> that upstream development happens on a Redmond OS
It does, see what binaries they say they provide.
I added some explanations to the upstream issues you filed. You cannot really assume that students working on proprietary operating systems are familiar with Free Software, GNU/Linux and freedesktop.org concepts such as Free Software licensing or .desktop files. Maybe "Freely redistributable without restriction"? https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#.22Distributable.22 Or maybe "Public Domain"? https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Public_Domain Well, whatever upstream decides. You cannot do anything without upstream there, they own the copyright, so they're the only ones who can change the license (or in this case, add one). Upstream did not respond till now about license issue, so I'll close this request for now. |