Bug 1255680

Summary:	[ovirt-vmconsole] fails rpmlint validation
Product:	[oVirt] ovirt-vmconsole	Reporter:	Sandro Bonazzola <sbonazzo>
Component:	Packaging.rpm	Assignee:	Alon Bar-Lev <alonbl>
Status:	CLOSED NOTABUG	QA Contact:	Pavel Stehlik <pstehlik>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	master	CC:	bazulay, bugs, fromani, iheim, oourfali
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-08-21 10:22:56 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Sandro Bonazzola 2015-08-21 10:18:37 UTC

I'm not sure if this packges is meant to be included in Fedora, but being a vdsm dependency and being vdsm in Fedora I checked it, ovirt-vmconsole is failing rpmlint:

ovirt-vmconsole.noarch: W: hidden-file-or-dir /usr/share/ovirt-vmconsole/empty/.keep
ovirt-vmconsole.noarch: E: zero-length /usr/share/ovirt-vmconsole/empty/.keep
ovirt-vmconsole.noarch: W: hidden-file-or-dir /etc/pki/ovirt-vmconsole/.keep
ovirt-vmconsole.noarch: E: zero-length /etc/pki/ovirt-vmconsole/.keep
ovirt-vmconsole.noarch: W: non-conffile-in-etc /etc/pki/ovirt-vmconsole/.keep
ovirt-vmconsole.src: W: summary-not-capitalized C oVirt VM console
ovirt-vmconsole-host.noarch: W: summary-not-capitalized C oVirt VM console host components
ovirt-vmconsole-host.noarch: W: no-documentation
ovirt-vmconsole-host.noarch: W: non-conffile-in-etc /etc/ovirt-vmconsole/ovirt-vmconsole-host/conf.d/README
ovirt-vmconsole-proxy.noarch: W: summary-not-capitalized C oVirt VM console proxy components
ovirt-vmconsole-proxy.noarch: W: no-documentation
ovirt-vmconsole-proxy.noarch: W: non-conffile-in-etc /etc/ovirt-vmconsole/ovirt-vmconsole-proxy/conf.d/README

git hash: 3126bf1

Comment 1 Alon Bar-Lev 2015-08-21 10:22:56 UTC

1. it SHOULD NOT be vdsm dependency, having this is as such a mistake. it was designed as optional feature.

2.
.keep - no reason why not to keep, yes, it is zero length, yes, it is hidden.

3. summary is good.

4. README in conf.d is good.