Bug 1255889

Summary: second deployment lists hosts as available which were successfully used in a first deployment
Product: Red Hat Quickstart Cloud Installer Reporter: Dave Johnson <dajohnso>
Component: WebUIAssignee: John Matthews <jmatthew>
Status: VERIFIED --- QA Contact: Dave Johnson <dajohnso>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 1.0CC: jmatthew, tsanders
Target Milestone: betaKeywords: Triaged
Target Release: 1.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Dave Johnson 2015-08-21 19:25:07 UTC 
Description of problem:
===============================
You can create a second deployment after a successful first deployment and it will list the hosts used in the first deployment as available for the second deployment.  The UI should prevent listing hosts as available if they are at a minimum, not showing up in the discovered host list under Satellite.

This raises the question though as to what are the requirements here.  If I start a deployment selecting some hosts, save it, then create a second deployment, should the second deployment be able to see/use them despite being associated with the first deployment that was never completed?


Version-Release number of selected component (if applicable):
========================================
v6.0  0812 iso
Comment 1 John Matthews 2015-08-21 19:54:10 UTC 
I'd recommend for this BZ we focus on updating the webui to only list "Discovered Hosts" in Step 2B and 2C.  That should filter out previously used hosts that are now managed hosts.

I think this is a regression, in the past we would only show discovered hosts (or so I think, could be wrong), now we show all hosts the Satellite knows about.

Joseph,  the behavior I now see is:
1) I create 2 discovered hosts
2) I create a deployment and select those 2 discovered hosts
3) Deployment completes successfully
4) I attempt to create a 2nd deployment
5) I go to the select host screen Step 2B and I see the hosts I previously used listed.

I'd expect that I would see no hosts available, since I did not have any other discovered hosts available.

I think the fix we need is to ensure that Step 2B/C only list discovered hosts.  Once we use a host and complete provisioning it should change to a different kind of host, managed I think.  



dajo: in answer to your question....We haven't discussed this scenario.  My thoughts are that if the deployment was not run, then the hosts assigned to one deployment may be assigned to another, until a time that the deployment is executed and the hosts provision.  Once the hosts provision then they will change to become a ManagedHost and should not be usable again by our WebUI installer, until they are manually deleted from the Satellite and re-discovered.
Comment 2 jmagen@redhat.com 2015-08-24 08:18:00 UTC 
fixed. 
https://github.com/fusor/fusor/pull/323
Comment 4 Antonin Pagac 2015-09-04 12:28:01 UTC 
ISO: rc4 - RHCI-6.0-RHEL-7-20150829.0-RHCI-x86_64-dvd1.iso

The hosts used in first deployment are not displayed any more as available for second or subsequent deployments.